From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 6/6] spice: drop incorrect vm_change_state_handler() opaque
Date: Fri, 4 Jan 2013 14:55:50 +0100 [thread overview]
Message-ID: <1357307750-1966-7-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1357307750-1966-1-git-send-email-stefanha@redhat.com>
The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.
The vm change state handler is added with a pointer to the spice_server
pointer. This is useless and we probably would not want 2 levels of
pointers.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Uri Lublin <uril@redhat.com>
---
ui/spice-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3e44779..d83de2a 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -709,7 +709,7 @@ void qemu_spice_init(void)
qemu_spice_input_init();
qemu_spice_audio_init();
- qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
g_free(x509_key_file);
g_free(x509_cert_file);
@@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
*/
spice_server = spice_server_new();
spice_server_init(spice_server, &core_interface);
- qemu_add_vm_change_state_handler(vm_change_state_handler,
- &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
}
return spice_server_add_interface(spice_server, sin);
--
1.8.0.2
next prev parent reply other threads:[~2013-01-04 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 13:55 [Qemu-devel] [PULL 0/6] Trivial patches for 18 December 2012 to 4 January 2013 Stefan Hajnoczi
2013-01-04 13:55 ` [Qemu-devel] [PATCH 1/6] pc_sysfw: Check for qemu_find_file() failure Stefan Hajnoczi
2013-01-04 13:55 ` [Qemu-devel] [PATCH 2/6] pseries: Remove unneeded include statement (fixes MinGW builds) Stefan Hajnoczi
2013-01-04 13:55 ` [Qemu-devel] [PATCH 3/6] Remove --sparc_cpu option from the configure list Stefan Hajnoczi
2013-01-04 13:55 ` [Qemu-devel] [PATCH 4/6] hw/mcf5206: Reduce size of lookup table Stefan Hajnoczi
2013-01-04 13:55 ` [Qemu-devel] [PATCH 5/6] linux-user/syscall.c: remove forward declarations Stefan Hajnoczi
2013-01-04 13:55 ` Stefan Hajnoczi [this message]
2013-01-04 20:21 ` [Qemu-devel] [PULL 0/6] Trivial patches for 18 December 2012 to 4 January 2013 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357307750-1966-7-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).