From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr7kz-00020X-J3 for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:56:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tr7kw-0007S0-OG for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:56:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr7kw-0007Rw-GW for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:56:18 -0500 From: Stefan Hajnoczi Date: Fri, 4 Jan 2013 14:55:50 +0100 Message-Id: <1357307750-1966-7-git-send-email-stefanha@redhat.com> In-Reply-To: <1357307750-1966-1-git-send-email-stefanha@redhat.com> References: <1357307750-1966-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 6/6] spice: drop incorrect vm_change_state_handler() opaque List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Stefan Hajnoczi The spice_server pointer is a global variable and vm_change_state_handler() therefore does not use its opaque parameter. The vm change state handler is added with a pointer to the spice_server pointer. This is useless and we probably would not want 2 levels of pointers. Signed-off-by: Stefan Hajnoczi Reviewed-by: Uri Lublin --- ui/spice-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 3e44779..d83de2a 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -709,7 +709,7 @@ void qemu_spice_init(void) qemu_spice_input_init(); qemu_spice_audio_init(); - qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server); + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); g_free(x509_key_file); g_free(x509_cert_file); @@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin) */ spice_server = spice_server_new(); spice_server_init(spice_server, &core_interface); - qemu_add_vm_change_state_handler(vm_change_state_handler, - &spice_server); + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); } return spice_server_add_interface(spice_server, sin); -- 1.8.0.2