From: Onkar N Mahajan <onmahaja@linux.vnet.ibm.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Anthony Liguori <aligouri@us.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.
Date: Fri, 04 Jan 2013 21:02:28 +0530 [thread overview]
Message-ID: <1357313548.13838.2.camel@oc2826874472.ibm.com> (raw)
Running qemu-img commit on QED image emits the below message even if the
image is never committed. This patch fixes this. Do we need to do any
L1, L2 table cleanup here ? I see that cleanup code is commented out in
the case of qcow2 (qcow2_make_empty).
before patching -
# qemu-img commit -f qed ss.qed
qemu-img: Image is already committed
even before committing the image.
after patching -
# qemu-img commit -f qed ss.qed
Image committed.
and image is actually successfully committed.
***
Signed-off-by: Onkar N Mahajan/India/IBM
<onkar.n.mahajan@linux.vnet.ibm.com>
---
block/qed.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index 6c182ca..32f1d53 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -695,7 +695,7 @@ static int coroutine_fn
bdrv_qed_co_is_allocated(BlockDriverState *bs,
static int bdrv_qed_make_empty(BlockDriverState *bs)
{
- return -ENOTSUP;
+ return 0;
}
static BDRVQEDState *acb_to_s(QEDAIOCB *acb)
--
1.7.1
--
next reply other threads:[~2013-01-04 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 15:32 Onkar N Mahajan [this message]
2013-01-04 17:25 ` [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support Stefan Hajnoczi
2013-01-04 20:21 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-01-04 10:02 Onkar N Mahajan
2013-01-04 20:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357313548.13838.2.camel@oc2826874472.ibm.com \
--to=onmahaja@linux.vnet.ibm.com \
--cc=aligouri@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).