From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 4/9] target-i386: check/enforce: Do not ignore "hypervisor" flag
Date: Fri, 4 Jan 2013 13:37:39 -0200 [thread overview]
Message-ID: <1357313864-31026-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1357313864-31026-1-git-send-email-ehabkost@redhat.com>
We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because
kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly.
So, this shouldn't introduce any behavior change, but it makes the code
simpler.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
My goal is to eliminate the check_feat field completely, as
kvm_arch_get_supported_cpuid() should now really return all the bits we
can set on all CPUID leaves.
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6c43ace..f1a21cf 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -965,7 +965,7 @@ static int kvm_check_features_against_host(x86_def_t *guest_def)
{&guest_def->features, &host_def.features,
~0, feature_name, 0x00000001, R_EDX},
{&guest_def->ext_features, &host_def.ext_features,
- ~CPUID_EXT_HYPERVISOR, ext_feature_name, 0x00000001, R_ECX},
+ ~0, ext_feature_name, 0x00000001, R_ECX},
{&guest_def->ext2_features, &host_def.ext2_features,
~PPRO_FEATURES, ext2_feature_name, 0x80000001, R_EDX},
{&guest_def->ext3_features, &host_def.ext3_features,
--
1.7.11.7
next prev parent reply other threads:[~2013-01-04 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 15:37 [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 1/9] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 2/9] target-i386: kvm: Enable all supported KVM features for -cpu host Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 3/9] target-i386: check/enforce: Fix CPUID leaf numbers on error messages Eduardo Habkost
2013-01-04 20:54 ` Blue Swirl
2013-01-04 15:37 ` Eduardo Habkost [this message]
2013-01-04 15:37 ` [Qemu-devel] [PATCH 5/9] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 6/9] target-i386: check/enforce: Check SVM flag support as well Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 7/9] target-i386: check/enforce: Eliminate check_feat field Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 8/9] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set Eduardo Habkost
2013-01-04 15:37 ` [Qemu-devel] [PATCH 9/9] target-i386: check/enforce: Check all feature words Eduardo Habkost
[not found] ` <201301042020.r04KKv0R014816@d01av02.pok.ibm.com>
2013-01-04 20:48 ` [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should Eduardo Habkost
2013-01-04 21:10 ` Anthony Liguori
2013-01-04 21:00 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357313864-31026-5-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).