From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr9Jg-0003vy-Aq for qemu-devel@nongnu.org; Fri, 04 Jan 2013 10:36:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tr9Jd-0004cB-Tg for qemu-devel@nongnu.org; Fri, 04 Jan 2013 10:36:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr9Jd-0004bw-MA for qemu-devel@nongnu.org; Fri, 04 Jan 2013 10:36:13 -0500 From: Eduardo Habkost Date: Fri, 4 Jan 2013 13:37:40 -0200 Message-Id: <1357313864-31026-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1357313864-31026-1-git-send-email-ehabkost@redhat.com> References: <1357313864-31026-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 5/9] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , kvm@vger.kernel.org I have no idea why PPRO_FEATURES was being ignored on the check of the CPUID.80000001H.EDX bits. I believe it was a mistake, and it was supposed to be ~(PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) or just ~CPUID_EXT2_AMD_ALIASES, because some time ago kvm_cpu_fill_host() used the CPUID instruction directly (instead of kvm_arch_get_supported_cpuid()). But now kvm_cpu_fill_host() use kvm_arch_get_supported_cpuid(), and kvm_arch_get_supported_cpuid() returns all supported bits for CPUID.80000001H.EDX, even the AMD aliases (that are explicitly copied from CPUID.01H.EDX), so we can make the code check/enforce all the CPUID.80000001H.EDX bits. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1a21cf..13075c7 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -967,7 +967,7 @@ static int kvm_check_features_against_host(x86_def_t *guest_def) {&guest_def->ext_features, &host_def.ext_features, ~0, ext_feature_name, 0x00000001, R_ECX}, {&guest_def->ext2_features, &host_def.ext2_features, - ~PPRO_FEATURES, ext2_feature_name, 0x80000001, R_EDX}, + ~0, ext2_feature_name, 0x80000001, R_EDX}, {&guest_def->ext3_features, &host_def.ext3_features, ~CPUID_EXT3_SVM, ext3_feature_name, 0x80000001, R_ECX}}; -- 1.7.11.7