From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality
Date: Fri, 4 Jan 2013 13:07:24 -0600 [thread overview]
Message-ID: <1357326444.666.11@snotra> (raw)
In-Reply-To: <03A8D1A7-BBDC-4D05-930D-D28FFEF2AB71@suse.de> (from agraf@suse.de on Fri Jan 4 12:54:51 2013)
On 01/04/2013 12:54:51 PM, Alexander Graf wrote:
>
> On 04.01.2013, at 19:50, Scott Wood wrote:
>
> > On 01/04/2013 04:24:59 AM, Alexander Graf wrote:
> >> msi_supported = true;
> >> list = list_be;
> >> diff --git a/target-ppc/Makefile.objs b/target-ppc/Makefile.objs
> >> index 237a0ed..6c11ef8 100644
> >> --- a/target-ppc/Makefile.objs
> >> +++ b/target-ppc/Makefile.objs
> >> @@ -9,4 +9,3 @@ obj-y += mmu_helper.o
> >> obj-y += timebase_helper.o
> >> obj-y += misc_helper.o
> >> obj-y += mem_helper.o
> >> -obj-y += mpic_helper.o
> >> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> >> index e88ebe0..0db06d6 100644
> >> --- a/target-ppc/cpu.h
> >> +++ b/target-ppc/cpu.h
> >> @@ -1068,6 +1068,8 @@ struct CPUPPCState {
> >> target_ulong ivpr_mask;
> >> target_ulong hreset_vector;
> >> hwaddr mpic_cpu_base;
> >> + /* true when the external proxy facility mode is enabled */
> >> + int mpic_proxy;
> >> #endif
> >
> > bool?
>
> IIRC we can't save/restore bools easily using savevm, and this one
> should be saved/restored.
I see bool handlers in savevm.c. I'm not sure how a non-fixed-size
"int" is better.
BTW, docs/migration.txt says that savevm is the "legacy" approach.
-Scott
next prev parent reply other threads:[~2013-01-04 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 10:24 [Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality Alexander Graf
2013-01-04 18:50 ` Scott Wood
2013-01-04 18:54 ` Alexander Graf
2013-01-04 19:07 ` Scott Wood [this message]
2013-01-04 22:57 ` Alexander Graf
2013-01-04 20:21 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-01-04 23:36 Alexander Graf
2013-01-07 17:42 ` Scott Wood
2013-01-07 17:50 ` Alexander Graf
2013-01-07 19:04 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357326444.666.11@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).