qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, "Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH qom-cpu 00/11] disable-kvm_mmu + -cpu check/enforce fixes (v2)
Date: Fri,  4 Jan 2013 20:01:01 -0200	[thread overview]
Message-ID: <1357336872-7200-1-git-send-email-ehabkost@redhat.com> (raw)

Changes on v2:
 - Now both the kvm_mmu-disable and -cpu "enforce" changes are on the same
   series
 - Coding style fixes

Git tree for reference:
  git://github.com/ehabkost/qemu-hacks.git cpu-enforce-all.v2
  https://github.com/ehabkost/qemu-hacks/tree/cpu-enforce-all.v2

Patches 1-2 disable the "kvm_mmu" feature by default on pc-1.4. Host-side
support for the kvm_mmu feature was removed from the kernel since v3.3
(released in March 2012), it was marked for removal since January 2011 and it's
slower than shadow or hardware assisted paging (see kernel commit fb92045843).
It doesn't make sense to keep it enabled by default.

Also, keeping it enabled by default would cause unnecessary hassle when
libvirt start using the "enforce" option.

Patches 3-11 change the -cpu check/enforce code to work as it should: it will
check every single CPUID bit to make sure it is supported by the host.

The changes are a bit intrusive, but:

 - The longer we take to make "enforce" strict as it should (and make libvirt
   finally use it), more users will have VMs with migration-unsafe unpredictable
   guest ABIs. For this reason, I would like to get this into QEMU 1.4.
 - The changes in this series should affect only users that are already using
   the "enforce" flag, and I believe whoever is using the "enforce" flag really
   want the strict behavior introduced by this series.


Eduardo Habkost (11):
  target-i386: Don't set any KVM flag by default if KVM is disabled
  target-i386: Disable kvm_mmu_op by default on pc-1.4
  target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features
  target-i386: kvm: Enable all supported KVM features for -cpu host
  target-i386: check/enforce: Fix CPUID leaf numbers on error messages
  target-i386: check/enforce: Do not ignore "hypervisor" flag
  target-i386: check/enforce: Check all CPUID.80000001H.EDX bits
  target-i386: check/enforce: Check SVM flag support as well
  target-i386: check/enforce: Eliminate check_feat field
  target-i386: Call kvm_check_features_against_host() only if
    CONFIG_KVM is set
  target-i386: check/enforce: Check all feature words

 hw/pc_piix.c      |  9 +++++-
 target-i386/cpu.c | 93 +++++++++++++++++++++++++++++++++++++++++--------------
 target-i386/cpu.h |  4 +++
 3 files changed, 81 insertions(+), 25 deletions(-)

-- 
1.7.11.7

             reply	other threads:[~2013-01-04 21:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 22:01 Eduardo Habkost [this message]
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled Eduardo Habkost
2013-01-06 11:32   ` Gleb Natapov
2013-01-07 11:42     ` Eduardo Habkost
2013-01-07 11:42       ` Gleb Natapov
2013-01-07 12:09         ` Eduardo Habkost
2013-01-07 12:15           ` Gleb Natapov
2013-01-07 12:30             ` Eduardo Habkost
2013-01-07 12:33               ` Gleb Natapov
2013-01-07 13:01                 ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 02/11] target-i386: Disable kvm_mmu_op by default on pc-1.4 Eduardo Habkost
2013-01-06 13:38   ` Gleb Natapov
2013-01-07 11:45     ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 03/11] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features Eduardo Habkost
2013-01-06 13:51   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 04/11] target-i386: kvm: Enable all supported KVM features for -cpu host Eduardo Habkost
2013-01-06 13:52   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 05/11] target-i386: check/enforce: Fix CPUID leaf numbers on error messages Eduardo Habkost
2013-01-06 14:12   ` Gleb Natapov
2013-01-06 14:15     ` Gleb Natapov
2013-01-07 11:54     ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 06/11] target-i386: check/enforce: Do not ignore "hypervisor" flag Eduardo Habkost
2013-01-06 14:24   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 07/11] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits Eduardo Habkost
2013-01-06 14:24   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 08/11] target-i386: check/enforce: Check SVM flag support as well Eduardo Habkost
2013-01-06 14:25   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 09/11] target-i386: check/enforce: Eliminate check_feat field Eduardo Habkost
2013-01-06 14:25   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set Eduardo Habkost
2013-01-06 14:27   ` Gleb Natapov
2013-01-07 12:00     ` Eduardo Habkost
2013-01-07 13:15       ` Igor Mammedov
2013-01-07 13:30         ` Gleb Natapov
2013-01-07 14:13           ` Igor Mammedov
2013-01-07 13:30         ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words Eduardo Habkost
2013-01-06 14:35   ` Gleb Natapov
2013-01-07 12:06     ` Eduardo Habkost
2013-01-07 12:06       ` Gleb Natapov
2013-01-07 12:19         ` Eduardo Habkost
2013-01-07 12:23           ` Gleb Natapov
2013-01-07 18:04 ` [Qemu-devel] [PATCH qom-cpu 00/11] disable-kvm_mmu + -cpu check/enforce fixes (v2) Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357336872-7200-1-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).