qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, "Gleb Natapov" <gleb@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	libvir-list@redhat.com, "Marcelo Tosatti" <mtosatti@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-cpu 04/11] target-i386: kvm: Enable all supported KVM features for -cpu host
Date: Fri,  4 Jan 2013 20:01:05 -0200	[thread overview]
Message-ID: <1357336872-7200-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1357336872-7200-1-git-send-email-ehabkost@redhat.com>

When using -cpu host, we don't need to use the kvm_default_features
variable, as the user is explicitly asking QEMU to enable all feature
supported by the host.

This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to
initialize the kvm_features field, so we get all host KVM features
enabled.

This will also allow use to properly check/enforce KVM features inside
kvm_check_features_against_host() later. For example, we will be able to
make this:

  $ qemu-system-x86_64 -cpu ...,+kvm_pv_eoi,enforce

refuse to start if kvm_pv_eoi is not supported by the host (after we fix
kvm_check_features_against_host() to check KVM flags as well).

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v2:
 - Coding style (indentation) fix

Cc: Gleb Natapov <gleb@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
---
 target-i386/cpu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index c49a97c..e916ae0 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -911,6 +911,8 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
     /* Other KVM-specific feature fields: */
     x86_cpu_def->svm_features =
         kvm_arch_get_supported_cpuid(s, 0x8000000A, 0, R_EDX);
+    x86_cpu_def->kvm_features =
+        kvm_arch_get_supported_cpuid(s, KVM_CPUID_FEATURES, 0, R_EAX);
 
 #endif /* CONFIG_KVM */
 }
-- 
1.7.11.7

  parent reply	other threads:[~2013-01-04 21:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 22:01 [Qemu-devel] [PATCH qom-cpu 00/11] disable-kvm_mmu + -cpu check/enforce fixes (v2) Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled Eduardo Habkost
2013-01-06 11:32   ` Gleb Natapov
2013-01-07 11:42     ` Eduardo Habkost
2013-01-07 11:42       ` Gleb Natapov
2013-01-07 12:09         ` Eduardo Habkost
2013-01-07 12:15           ` Gleb Natapov
2013-01-07 12:30             ` Eduardo Habkost
2013-01-07 12:33               ` Gleb Natapov
2013-01-07 13:01                 ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 02/11] target-i386: Disable kvm_mmu_op by default on pc-1.4 Eduardo Habkost
2013-01-06 13:38   ` Gleb Natapov
2013-01-07 11:45     ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 03/11] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features Eduardo Habkost
2013-01-06 13:51   ` Gleb Natapov
2013-01-04 22:01 ` Eduardo Habkost [this message]
2013-01-06 13:52   ` [Qemu-devel] [PATCH qom-cpu 04/11] target-i386: kvm: Enable all supported KVM features for -cpu host Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 05/11] target-i386: check/enforce: Fix CPUID leaf numbers on error messages Eduardo Habkost
2013-01-06 14:12   ` Gleb Natapov
2013-01-06 14:15     ` Gleb Natapov
2013-01-07 11:54     ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 06/11] target-i386: check/enforce: Do not ignore "hypervisor" flag Eduardo Habkost
2013-01-06 14:24   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 07/11] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits Eduardo Habkost
2013-01-06 14:24   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 08/11] target-i386: check/enforce: Check SVM flag support as well Eduardo Habkost
2013-01-06 14:25   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 09/11] target-i386: check/enforce: Eliminate check_feat field Eduardo Habkost
2013-01-06 14:25   ` Gleb Natapov
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set Eduardo Habkost
2013-01-06 14:27   ` Gleb Natapov
2013-01-07 12:00     ` Eduardo Habkost
2013-01-07 13:15       ` Igor Mammedov
2013-01-07 13:30         ` Gleb Natapov
2013-01-07 14:13           ` Igor Mammedov
2013-01-07 13:30         ` Eduardo Habkost
2013-01-04 22:01 ` [Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words Eduardo Habkost
2013-01-06 14:35   ` Gleb Natapov
2013-01-07 12:06     ` Eduardo Habkost
2013-01-07 12:06       ` Gleb Natapov
2013-01-07 12:19         ` Eduardo Habkost
2013-01-07 12:23           ` Gleb Natapov
2013-01-07 18:04 ` [Qemu-devel] [PATCH qom-cpu 00/11] disable-kvm_mmu + -cpu check/enforce fixes (v2) Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357336872-7200-5-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=gleb@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).