From: Lei Li <lilei@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com,
Lei Li <lilei@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/3] qga: add guest-set-time command
Date: Sun, 6 Jan 2013 18:07:00 +0800 [thread overview]
Message-ID: <1357466820-12860-4-git-send-email-lilei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
qga/commands-posix.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
qga/qapi-schema.json | 32 ++++++++++++++++++++++++++++
2 files changed, 89 insertions(+), 0 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 190199d..7fff49a 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -121,6 +121,63 @@ struct HostTimeInfo *qmp_guest_get_time(Error **errp)
return host_time;
}
+void qmp_guest_set_time(bool has_seconds, int64_t seconds,
+ bool has_microseconds, int64_t microseconds,
+ bool has_utc_offset, int64_t utc_offset, Error **errp)
+{
+ int ret;
+ int status;
+ pid_t pid, rpid;
+ struct timeval tv;
+ HostTimeInfo *host_time;
+
+ if ((!has_seconds) && (!has_microseconds) && (!has_utc_offset)) {
+ host_time = get_host_time();
+ if (!host_time) {
+ error_set(errp, QERR_QGA_COMMAND_FAILED, "Failed to set guest time");
+ return;
+ }
+ tv.tv_sec = host_time->seconds;
+ tv.tv_usec = host_time->microseconds;
+ } else if (has_seconds && has_microseconds && has_utc_offset) {
+ tv.tv_sec = (time_t) seconds + utc_offset;
+ tv.tv_usec = (time_t) microseconds;
+ } else {
+ error_set(errp, QERR_INVALID_PARAMETER, "parameter missing");
+ return;
+ }
+
+ ret = settimeofday(&tv, NULL);
+ if (ret < 0) {
+ error_set(errp, QERR_QGA_COMMAND_FAILED, strerror(errno));
+ return;
+ }
+
+ /* Set the Hardware Clock to the current System Time. */
+ pid = fork();
+ if (pid == 0) {
+ setsid();
+ reopen_fd_to_null(0);
+ reopen_fd_to_null(1);
+ reopen_fd_to_null(2);
+
+ execle("/sbin/hwclock", "hwclock", "-w", NULL, environ);
+ _exit(EXIT_FAILURE);
+ } else if (pid < 0) {
+ goto exit_err;
+ }
+
+ do {
+ rpid = waitpid(pid, &status, 0);
+ } while (rpid == -1 && errno == EINTR);
+ if (rpid == pid && WIFEXITED(status) && !WEXITSTATUS(status)) {
+ return;
+ }
+
+exit_err:
+ error_set(errp, QERR_UNDEFINED_ERROR);
+}
+
typedef struct GuestFileHandle {
uint64_t id;
FILE *fh;
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 4a8b93c..4649b55 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -117,6 +117,38 @@
'returns': 'HostTimeInfo' }
##
+# @guest-set-time:
+#
+# Set guest time. If none arguments were given, will set
+# host time to guest.
+#
+# Right now, when a guest is paused or migrated to a file
+# then loaded from that file, the guest OS has no idea that
+# there was a big gap in the time. Depending on how long
+# the gap was, NTP might not be able to resynchronize the
+# guest.
+#
+# This command tries to set guest time based on the information
+# from host or an absolute value given by management app, and
+# set the Hardware Clock to the current System Time. This
+# will make it easier for a guest to resynchronize without
+# waiting for NTP.
+#
+# @seconds: #optional "seconds" time.
+#
+# @microseconds: #optional "microseconds" time.
+#
+# @utc-offset: #optional utc offset.
+#
+# Returns: Nothing on success.
+#
+# Since: 1.4
+##
+{ 'command': 'guest-set-time',
+ 'data': { '*seconds': 'int', '*microseconds': 'int',
+ '*utc-offset': 'int' } }
+
+##
# @GuestAgentCommandInfo:
#
# Information about guest agent commands.
--
1.7.7.6
next prev parent reply other threads:[~2013-01-06 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 10:06 [Qemu-devel] [RFC PATCH 0/3] Time resync support by qemu-ga Lei Li
2013-01-06 10:06 ` [Qemu-devel] [PATCH 1/3] qga: add support to get host time Lei Li
2013-01-07 21:52 ` Eric Blake
2013-01-11 7:18 ` Lei Li
2013-01-11 15:37 ` Eric Blake
2013-01-14 3:17 ` Lei Li
2013-01-14 14:23 ` Eric Blake
2013-01-09 13:32 ` Luiz Capitulino
2013-01-11 7:19 ` Lei Li
2013-01-11 11:14 ` Luiz Capitulino
2013-01-09 15:36 ` mdroth
2013-01-11 7:20 ` Lei Li
2013-01-06 10:06 ` [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command Lei Li
2013-01-07 22:04 ` Eric Blake
2013-01-11 7:37 ` Lei Li
2013-01-11 17:28 ` mdroth
2013-01-09 13:33 ` Luiz Capitulino
2013-01-11 7:50 ` Lei Li
2013-01-06 10:07 ` Lei Li [this message]
2013-01-07 22:26 ` [Qemu-devel] [PATCH 3/3] qga: add guest-set-time command Eric Blake
2013-01-11 8:00 ` Lei Li
2013-01-09 13:40 ` Luiz Capitulino
2013-01-11 8:03 ` Lei Li
2013-01-07 19:01 ` [Qemu-devel] [RFC PATCH 0/3] Time resync support by qemu-ga Eric Blake
2013-01-11 7:36 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357466820-12860-4-git-send-email-lilei@linux.vnet.ibm.com \
--to=lilei@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).