qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Scott Wood <scottwood@freescale.com>,
	qemu-ppc@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 12/31] openpic: lower interrupt when reading the MSI register
Date: Mon,  7 Jan 2013 16:38:41 +0100	[thread overview]
Message-ID: <1357573140-8877-13-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1357573140-8877-1-git-send-email-agraf@suse.de>

From: Scott Wood <scottwood@freescale.com>

This will stop things from breaking once it's properly treated as a
level-triggered interrupt.  Note that it's the MPIC's MSI cascade
interrupts that are level-triggered; the individual MSIs are
edge-triggered.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/openpic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/openpic.c b/hw/openpic.c
index 9243e70..f4df66d 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -810,6 +810,7 @@ static uint64_t openpic_msi_read(void *opaque, hwaddr addr, unsigned size)
         r = opp->msi[srs].msir;
         /* Clear on read */
         opp->msi[srs].msir = 0;
+        openpic_set_irq(opp, opp->irq_msi + srs, 0);
         break;
     case 0x120: /* MSISR */
         for (i = 0; i < MAX_MSI; i++) {
-- 
1.6.0.2

  parent reply	other threads:[~2013-01-07 15:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 15:38 [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07 Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 01/31] openpic: symbolicize some magic numbers Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 02/31] openpic: remove pcsr (CPU sensitivity register) Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 03/31] openpic: support large vectors on FSL mpic Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 04/31] openpic: BRR1 is not a CPU-specific register Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 05/31] openpic: s/opp->nb_irqs -1/opp->nb_cpus - 1/ Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 06/31] openpic: don't crash on a register access without a CPU context Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 07/31] powerpc: linux header sync script includes epapr_hcalls.h Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 08/31] openpic: fix coding style issues Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 09/31] PPC: Reset qemu timers when guest reset Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 10/31] PPC: fix segfault in signal handling code Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 11/31] openpic: fix debug prints Alexander Graf
2013-01-07 15:38 ` Alexander Graf [this message]
2013-01-07 15:38 ` [Qemu-devel] [PATCH 13/31] ppc/booke: fix crit/mcheck/debug exceptions Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 14/31] openpic: make register names correspond better with hw docs Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 15/31] openpic: rework critical interrupt support Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 16/31] openpic: make ctpr signed Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 17/31] openpic/fsl: critical interrupts ignore mask before v4.1 Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 18/31] openpic: always call IRQ_check from IRQ_get_next Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 19/31] Revert "openpic: Accelerate pending irq search" Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 20/31] openpic: use standard bitmap operations Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 21/31] openpic: add some bounds checking for IRQ numbers Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 22/31] openpic: fix sense and priority bits Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 23/31] openpic: IRQ_check: search the queue a word at a time Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 24/31] openpic: move IACK to its own function Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 25/31] openpic: fix CTPR and de-assertion of interrupts Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 26/31] kvm: Update kernel headers Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 27/31] PPC: KVM: set has-idle in guest device tree Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 28/31] PPC: Bring EPR support closer to reality Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 29/31] target-ppc: Slim conversion of model definitions to QOM subclasses Alexander Graf
2013-01-07 15:38 ` [Qemu-devel] [PATCH 30/31] target-ppc: Error out for -cpu host on unknown PVR Alexander Graf
2013-01-07 15:39 ` [Qemu-devel] [PATCH 31/31] PPC: linux-user: Calculate context pointer explicitly Alexander Graf
2013-01-07 16:21 ` [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07 Andreas Färber
2013-01-07 16:40   ` Alexander Graf
2013-01-08  8:54     ` Stefan Hajnoczi
2013-01-08  9:12       ` Alexander Graf
2013-01-08 15:49       ` Richard Henderson
2013-01-12 16:13     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357573140-8877-13-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).