From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsEn7-0004Gv-FK for qemu-devel@nongnu.org; Mon, 07 Jan 2013 10:39:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsEn5-00074J-NZ for qemu-devel@nongnu.org; Mon, 07 Jan 2013 10:39:09 -0500 From: Alexander Graf Date: Mon, 7 Jan 2013 16:38:34 +0100 Message-Id: <1357573140-8877-6-git-send-email-agraf@suse.de> In-Reply-To: <1357573140-8877-1-git-send-email-agraf@suse.de> References: <1357573140-8877-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 05/31] openpic: s/opp->nb_irqs -1/opp->nb_cpus - 1/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Scott Wood , qemu-ppc@nongnu.org, Aurelien Jarno From: Scott Wood "opp->nb_irqs-1" would have been a minor coding style error, but putting in one space but not the other makes it look confusingly like a numeric literal "-1". Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- hw/openpic.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 337dbf5..10dbdf7 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @@ -440,8 +440,8 @@ static void openpic_reset(DeviceState *d) opp->glbc = GLBC_RESET; /* Initialise controller registers */ - opp->frep = ((opp->nb_irqs -1) << FREP_NIRQ_SHIFT) | - ((opp->nb_cpus -1) << FREP_NCPU_SHIFT) | + opp->frep = ((opp->nb_irqs - 1) << FREP_NIRQ_SHIFT) | + ((opp->nb_cpus - 1) << FREP_NCPU_SHIFT) | (opp->vid << FREP_VID_SHIFT); opp->pint = 0; -- 1.6.0.2