qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: fred.konrad@greensocs.com
To: qemu-devel@nongnu.org, aliguori@us.ibm.com
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
	e.voevodin@samsung.com, mst@redhat.com,
	mark.burton@greensocs.com, agraf@suse.de, amit.shah@redhat.com,
	aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com,
	cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de,
	fred.konrad@greensocs.com
Subject: [Qemu-devel] [PATCH 56/61] virtio-9p : cleanup : QOM casts.
Date: Mon,  7 Jan 2013 19:41:09 +0100	[thread overview]
Message-ID: <1357584074-10852-57-git-send-email-fred.konrad@greensocs.com> (raw)
In-Reply-To: <1357584074-10852-1-git-send-email-fred.konrad@greensocs.com>

From: KONRAD Frederic <fred.konrad@greensocs.com>

As the virtio-9p-pci is switched to the new API, we can use QOM casts.
This shouldn't been applyied before virtio-9p-pci refactoring as its
VirtIODevice was not a QOM object.

Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
---
 hw/9pfs/virtio-9p-device.c | 11 +++--------
 hw/9pfs/virtio-9p.c        |  2 +-
 hw/9pfs/virtio-9p.h        |  2 +-
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 02f01ae..a99ff5a 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -26,16 +26,11 @@ static uint32_t virtio_9p_get_features(VirtIODevice *vdev, uint32_t features)
     return features;
 }
 
-static V9fsState *to_virtio_9p(VirtIODevice *vdev)
-{
-    return (V9fsState *)vdev;
-}
-
 static void virtio_9p_get_config(VirtIODevice *vdev, uint8_t *config)
 {
     int len;
     struct virtio_9p_config *cfg;
-    V9fsState *s = to_virtio_9p(vdev);
+    V9fsState *s = VIRTIO_9P(vdev);
 
     len = strlen(s->tag);
     cfg = g_malloc0(sizeof(struct virtio_9p_config) + len);
@@ -107,9 +102,9 @@ static int virtio_9p_device_init(VirtIODevice *vdev)
     s->ctx.uid = -1;
 
     s->ops = fse->ops;
-    s->vdev.get_features = virtio_9p_get_features;
+    vdev->get_features = virtio_9p_get_features;
     s->config_size = sizeof(struct virtio_9p_config) + len;
-    s->vdev.get_config = virtio_9p_get_config;
+    vdev->get_config = virtio_9p_get_config;
     s->fid_list = NULL;
     qemu_co_rwlock_init(&s->rename_lock);
 
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 0aaf0d2..aedea0c 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -631,7 +631,7 @@ static void complete_pdu(V9fsState *s, V9fsPDU *pdu, ssize_t len)
     virtqueue_push(s->vq, &pdu->elem, len);
 
     /* FIXME: we should batch these completions */
-    virtio_notify(&s->vdev, s->vq);
+    virtio_notify(VIRTIO_DEVICE(s), s->vq);
 
     /* Now wakeup anybody waiting in flush for this request */
     qemu_co_queue_next(&pdu->complete);
diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index 9b342dc..f21e33f 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -207,7 +207,7 @@ struct V9fsFidState
 
 typedef struct V9fsState
 {
-    VirtIODevice vdev;
+    VirtIODevice parent_obj;
     VirtQueue *vq;
     V9fsPDU pdus[MAX_REQ];
     QLIST_HEAD(, V9fsPDU) free_list;
-- 
1.7.11.7

  parent reply	other threads:[~2013-01-07 18:50 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 18:40 [Qemu-devel] [PATCH 00/61] Virtio refactoring fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 01/61] qdev : add a maximum device allowed field for the bus fred.konrad
2013-01-08 17:05   ` Peter Maydell
2013-01-07 18:40 ` [Qemu-devel] [PATCH 02/61] virtio-bus : introduce virtio-bus fred.konrad
2013-01-08 17:09   ` Peter Maydell
2013-01-07 18:40 ` [Qemu-devel] [PATCH 03/61] virtio-pci-bus : introduce virtio-pci-bus fred.konrad
2013-01-08 18:08   ` Peter Maydell
2013-01-09  8:37     ` KONRAD Frédéric
2013-01-09  9:14       ` KONRAD Frédéric
2013-01-09 14:53         ` Peter Maydell
2013-01-09 14:55           ` KONRAD Frédéric
2013-01-07 18:40 ` [Qemu-devel] [PATCH 04/61] virtio-pci : refactor virtio-pci device fred.konrad
2013-01-08 17:54   ` Peter Maydell
2013-01-09  8:45     ` KONRAD Frédéric
2013-01-09 14:33       ` Peter Maydell
2013-01-07 18:40 ` [Qemu-devel] [PATCH 05/61] virtio-device : refactor virtio-device fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 06/61] virtio-s390-bus : add virtio-s390-bus fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 07/61] virtio-s390-device : create a virtio-s390-bus during init fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure fred.konrad
2013-01-08 16:18   ` Peter Maydell
2013-01-07 18:40 ` [Qemu-devel] [PATCH 09/61] virtio-blk : don't use pointer for configuration fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 10/61] virtio-blk : add the virtio-blk device fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 11/61] virtio-blk-pci : switch to new API fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 12/61] virtio-blk-s390 : switch to the " fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 13/61] virtio-blk : cleanup : use QOM cast fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 14/61] virtio-blk : cleanup : remove qdev field fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 15/61] virtio-net : show the VirtIONet structure fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 16/61] virtio-net : add the virtio-net device fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 17/61] virtio-net-pci : switch to the new API fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 18/61] virtio-net-s390 " fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 19/61] virtio-net : cleanup : use QOM cast fred.konrad
2013-01-07 21:16   ` Michael S. Tsirkin
2013-01-07 21:17     ` Anthony Liguori
2013-01-07 21:33       ` Michael S. Tsirkin
2013-01-07 21:53         ` Anthony Liguori
2013-01-07 18:40 ` [Qemu-devel] [PATCH 20/61] virtio-net : cleanup : init and exit function fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 21/61] virtio-net : cleanup : remove qdev field fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 22/61] virtio-scsi : show the VirtIOSCSI structure fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 23/61] virtio-scsi : don't use pointer for configuration fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 24/61] virtio-scsi : allocate cmd_vqs array separately fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 25/61] virtio-scsi : moving host_features from properties to transport properties fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 26/61] virtio-scsi : add the virtio-scsi device fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 27/61] virtio-scsi-pci : switch to new API fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 28/61] virtio-scsi-s390 : switch to the " fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 29/61] virtio-scsi : cleanup : use QOM casts fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 30/61] virtio-scsi : cleanup : init and exit functions fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 31/61] virtio-scsi : cleanup : remove qdev field fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 32/61] virtio-balloon : show the VirtIOBalloon structure fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 33/61] virtio-balloon : add the virtio-balloon device fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 34/61] virtio-balloon-pci : switch to the new API fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 35/61] virtio-balloon : cleanup : init and exit function fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 36/61] virtio-balloon : cleanup : QOM casts fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 37/61] virtio-balloon : cleanup : remove qdev field fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 38/61] virtio-rng : show the VirtIORNG structure fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 39/61] virtio-rng : don't use pointer for configuration fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 40/61] virtio-rng : add virtio-rng device fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 41/61] virtio-rng-s390 : switch to the new API fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 42/61] virtio-rng-pci " fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 43/61] virtio-rng.c : cleanup : init and exit functions fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 44/61] virtio-rng.c : cleanup : remove qdev field fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 45/61] virtio-rng.c : cleanup : use QOM casts fred.konrad
2013-01-07 18:40 ` [Qemu-devel] [PATCH 46/61] virtio-serial : show structures fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 47/61] virtio-serial : add the virtio-serial device fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 48/61] virtio-serial-pci : switch to the new API fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 49/61] virtio-serial-s390 " fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 50/61] virtio-serial : cleanup : init and exit functions fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 51/61] virtio-serial : cleanup : use QOM casts fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 52/61] virtio-serial : cleanup : remove qdev field fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 53/61] virtio-9p : add the virtio-9p device fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 54/61] virtio-9p-pci : switch to the new API fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 55/61] virtio-9p : cleanup : init function fred.konrad
2013-01-07 18:41 ` fred.konrad [this message]
2013-01-07 18:41 ` [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer fred.konrad
2013-01-09 20:40   ` Blue Swirl
2013-01-09 21:44     ` KONRAD Frédéric
2013-01-12  9:50       ` Blue Swirl
2013-01-07 18:41 ` [Qemu-devel] [PATCH 58/61] virtio-pci : cleanup : init, exit and reset functions fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 59/61] s390-virtio-bus : cleanup fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 60/61] virtio : remove virtiobindings fred.konrad
2013-01-07 18:41 ` [Qemu-devel] [PATCH 61/61] virtio : cleanup : init and exit function fred.konrad
2013-01-07 19:11 ` [Qemu-devel] [PATCH 00/61] Virtio refactoring Anthony Liguori
2013-01-08 13:40   ` KONRAD Frédéric
2013-01-08 15:54   ` Peter Maydell
2013-01-08 16:22     ` Anthony Liguori
2013-01-08 16:25       ` Peter Maydell
2013-01-07 20:04 ` Michael S. Tsirkin
2013-01-07 20:15   ` Anthony Liguori
2013-01-08 14:21 ` Peter Maydell
2013-01-08 14:33   ` KONRAD Frédéric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357584074-10852-57-git-send-email-fred.konrad@greensocs.com \
    --to=fred.konrad@greensocs.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=e.voevodin@samsung.com \
    --cc=kwolf@redhat.com \
    --cc=mark.burton@greensocs.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).