From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsI0C-0007rA-En for qemu-devel@nongnu.org; Mon, 07 Jan 2013 14:04:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsI0A-0003l2-2v for qemu-devel@nongnu.org; Mon, 07 Jan 2013 14:04:52 -0500 Date: Mon, 7 Jan 2013 13:04:28 -0600 From: Scott Wood In-Reply-To: (from agraf@suse.de on Mon Jan 7 11:50:02 2013) Message-ID: <1357585468.1113.4@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 01/07/2013 11:50:02 AM, Alexander Graf wrote: > >> @@ -1407,6 +1425,9 @@ static int openpic_init(SysBusDevice *dev) > >> opp->irq_tim0 =3D FSL_MPIC_20_TMR_IRQ; > >> opp->irq_msi =3D FSL_MPIC_20_MSI_IRQ; > >> opp->brr1 =3D FSL_BRR1_IPID | FSL_BRR1_IPMJ | FSL_BRR1_IPMN; > >> + /* XXX really only available as of MPIC 4.0 */ > >> + opp->mpic_mode_mask =3D GCR_MODE_PROXY; > >> + > > > > Shouldn't mpic_mode_mask be set to GCR_MODE_MIXED for Raven? >=20 > Does Raven support the MIXED bit? Yes. It's part of the base openpic spec (though it calls the bit "8259 =20 pass through disable"). > Do you have a pointer to the spec? http://www.slac.stanford.edu/grp/cd/soft/vxworks/doc/cpu/pci/ppc/mcp750/mcp= 750pg.pdf -Scott=