From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJTR-00020V-Ex for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:39:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJTK-0005aL-HC for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:39:09 -0500 Received: from amsterdam.lcs.mit.edu ([18.26.4.9]:48411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJTK-0005Ye-C3 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:39:02 -0500 From: Nickolai Zeldovich Date: Mon, 7 Jan 2013 15:38:39 -0500 Message-Id: <1357591119-40326-1-git-send-email-nickolai@csail.mit.edu> Subject: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Nickolai Zeldovich memcpy() for overlapping regions is undefined behavior; use memmove() instead in readline_hist_add(). Signed-off-by: Nickolai Zeldovich --- readline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readline.c b/readline.c index 5fc9643..aeccc7b 100644 --- a/readline.c +++ b/readline.c @@ -248,8 +248,8 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline) if (idx == READLINE_MAX_CMDS) { /* Need to get one free slot */ free(rs->history[0]); - memcpy(rs->history, &rs->history[1], - (READLINE_MAX_CMDS - 1) * sizeof(char *)); + memmove(rs->history, &rs->history[1], + (READLINE_MAX_CMDS - 1) * sizeof(char *)); rs->history[READLINE_MAX_CMDS - 1] = NULL; idx = READLINE_MAX_CMDS - 1; } -- 1.7.10.4