From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsZvU-0001PA-IV for qemu-devel@nongnu.org; Tue, 08 Jan 2013 09:13:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsZvP-0000OP-Ty for qemu-devel@nongnu.org; Tue, 08 Jan 2013 09:13:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsZvP-0000OL-MV for qemu-devel@nongnu.org; Tue, 08 Jan 2013 09:13:07 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r08DF14f005002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Jan 2013 08:15:01 -0500 From: Gerd Hoffmann Date: Tue, 8 Jan 2013 14:14:40 +0100 Message-Id: <1357650894-16982-19-git-send-email-kraxel@redhat.com> In-Reply-To: <1357650894-16982-1-git-send-email-kraxel@redhat.com> References: <1357650894-16982-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 18/32] usb: Fix usb_ep_find_packet_by_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Gerd Hoffmann From: Hans de Goede usb_ep_find_packet_by_id mistakenly only checks the first packet and if that is not a match, keeps trying the first packet! This patch fixes this. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index e315fc1..d057aab 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -761,7 +761,7 @@ USBPacket *usb_ep_find_packet_by_id(USBDevice *dev, int pid, int ep, struct USBEndpoint *uep = usb_ep_get(dev, pid, ep); USBPacket *p; - while ((p = QTAILQ_FIRST(&uep->queue)) != NULL) { + QTAILQ_FOREACH(p, &uep->queue, queue) { if (p->id == id) { return p; } -- 1.7.1