qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 08/17] target-i386: kvm: Enable all supported KVM features for -cpu host
Date: Tue,  8 Jan 2013 21:56:25 +0100	[thread overview]
Message-ID: <1357678594-427-9-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1357678594-427-1-git-send-email-afaerber@suse.de>

From: Eduardo Habkost <ehabkost@redhat.com>

When using -cpu host, we don't need to use the kvm_default_features
variable, as the user is explicitly asking QEMU to enable all feature
supported by the host.

This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to
initialize the kvm_features field, so we get all host KVM features
enabled.

This will also allow us to properly check/enforce KVM features inside
kvm_check_features_against_host() later. For example, we will be able to
make this:

  $ qemu-system-x86_64 -cpu ...,+kvm_pv_eoi,enforce

refuse to start if kvm_pv_eoi is not supported by the host (after we fix
kvm_check_features_against_host() to check KVM flags as well).

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-i386/cpu.c |    2 ++
 1 Datei geändert, 2 Zeilen hinzugefügt(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 1e30015..2547bfa 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -900,6 +900,8 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
     /* Other KVM-specific feature fields: */
     x86_cpu_def->svm_features =
         kvm_arch_get_supported_cpuid(s, 0x8000000A, 0, R_EDX);
+    x86_cpu_def->kvm_features =
+        kvm_arch_get_supported_cpuid(s, KVM_CPUID_FEATURES, 0, R_EAX);
 
 #endif /* CONFIG_KVM */
 }
-- 
1.7.10.4

  parent reply	other threads:[~2013-01-08 20:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 20:56 [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08 Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 01/17] libqemustub: Add qemu_[un]register_reset() stubs Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 02/17] libqemustub: vmstate register/unregister stubs Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 03/17] libqemustub: sysbus_get_default() stub Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 04/17] qdev: Include qdev code into *-user, too Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 05/17] qdev: Don't assume existence of parent bus on unparenting Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 06/17] cpu: Change parent type to Device Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 07/17] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features Andreas Färber
2013-01-08 20:56 ` Andreas Färber [this message]
2013-01-08 20:56 ` [Qemu-devel] [PATCH 09/17] target-i386: check/enforce: Fix CPUID leaf numbers on error messages Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 10/17] target-i386: check/enforce: Do not ignore "hypervisor" flag Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 11/17] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 12/17] target-i386: check/enforce: Check SVM flag support as well Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 13/17] target-i386: check/enforce: Eliminate check_feat field Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 14/17] qemu-common.h: Make qemu_init_vcpu() stub static inline Andreas Färber
2013-01-08 21:32   ` Richard Henderson
2013-01-08 20:56 ` [Qemu-devel] [PATCH 15/17] target-i386: Filter out unsupported features at realize time Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 16/17] target-i386: Sanitize AMD's ext2_features " Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 17/17] target-i386: Explicitly set vendor for each built-in cpudef Andreas Färber
2013-01-08 21:56 ` [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08 Andreas Färber
2013-01-08 22:34   ` Anthony Liguori
2013-01-08 23:40     ` Andreas Färber
2013-01-08 22:29 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357678594-427-9-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).