From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 1/2] qemu-ga: ga_open_pidfile(): use qemu_open()
Date: Tue, 8 Jan 2013 19:26:25 -0200 [thread overview]
Message-ID: <1357680386-10904-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1357680386-10904-1-git-send-email-lcapitulino@redhat.com>
This ensures that O_CLOEXEC is passed to open(), this way the
pid file fd is not leaked to executed processes.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
qga/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index ba5fa1c..e4245cc 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -242,7 +242,7 @@ static bool ga_open_pidfile(const char *pidfile)
int pidfd;
char pidstr[32];
- pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
+ pidfd = qemu_open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
g_critical("Cannot lock pid file, %s", strerror(errno));
if (pidfd != -1) {
--
1.8.0
next prev parent reply other threads:[~2013-01-08 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 21:26 [Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes Luiz Capitulino
2013-01-08 21:26 ` Luiz Capitulino [this message]
2013-01-08 23:06 ` [Qemu-devel] [PATCH 1/2] qemu-ga: ga_open_pidfile(): use qemu_open() Eric Blake
2013-01-08 21:26 ` [Qemu-devel] [PATCH 2/2] qemu-ga: add ga_open_logfile() Luiz Capitulino
2013-01-08 23:09 ` Eric Blake
2013-01-09 4:13 ` [Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes Amos Kong
2013-01-10 21:24 ` mdroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357680386-10904-2-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).