From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsxfY-0002Ol-O4 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:34:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsxfX-00015L-Ec for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:34:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsxfX-00015D-5V for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:34:19 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r09FYIpC003172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Jan 2013 10:34:18 -0500 Message-ID: <1357745656.13501.0.camel@localhost> From: Pavel Hrdina Date: Wed, 09 Jan 2013 16:34:16 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/13] convert savevm to use qapi and introduce qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com Please remove from CC the bad address with c0m. On Wed, 2013-01-09 at 16:17 +0100, Pavel Hrdina wrote: > This patch series convert the savevm command into qapi and introduce QMP > command vm-snapshot-save. > It also rewrite error report for functions used by this command. > > Last patch introduce new functionality of savevm and vm-snapshot-save > that you cannot override existing snapshot without using 'force' parameter > and for QMP you have to always provide name parameter. > > Pavel Hrdina (13): > block: add error parameter to bdrv_snapshot_create() and related > functions > block: add error parameter to del_existing_snapshots() > savevm: add error parameter to qemu_savevm_state_begin() > savevm: add error parameter to qemu_savevm_state_iterate() > savevm: add error parameter to qemu_savevm_state_complete() > savevm: add error parameter to qemu_savevm_state() > qapi: Convert savevm > qemu-img: introduce qemu_img_handle_error > block: update return value from bdrv_snapshot_create > savevm: update return value from qemu_savevm_state_begin > savevm: update return value from qemu_savevm_state_complete > savevm: update return value from qemu_savevm_state > vm-snapshot-save: add force parameter > > block.c | 26 ++++++---- > block/qcow2-snapshot.c | 14 ++++-- > block/qcow2.h | 4 +- > block/rbd.c | 15 ++++-- > block/sheepdog.c | 21 ++++---- > hmp-commands.hx | 17 +++---- > hmp.c | 32 +++++++++++++ > hmp.h | 1 + > include/block/block.h | 3 +- > include/block/block_int.h | 3 +- > include/sysemu/sysemu.h | 8 ++-- > migration.c | 6 +-- > qapi-schema.json | 21 ++++++++ > qemu-img.c | 18 +++++-- > qmp-commands.hx | 32 +++++++++++++ > savevm.c | 120 +++++++++++++++++++++++++--------------------- > 16 files changed, 237 insertions(+), 104 deletions(-) >