From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtIGH-0001H6-2o for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:33:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtIGA-0002CZ-FQ for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:33:36 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:47363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtIGA-0002Bw-4j for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:33:30 -0500 Received: from blackfin.pond.sub.org (p5B32A660.dip.t-dialin.net [91.50.166.96]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 246EE9FE67 for ; Thu, 10 Jan 2013 14:33:26 +0100 (CET) From: Markus Armbruster Date: Thu, 10 Jan 2013 14:33:23 +0100 Message-Id: <1357824805-31574-2-git-send-email-armbru@redhat.com> In-Reply-To: <1357824805-31574-1-git-send-email-armbru@redhat.com> References: <1357824805-31574-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] ehci: Assert state machine is sane w.r.t. EHCIQueue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com Coverity worries the EHCIQueue pointer could be null when we pass it to functions that reference it. The state machine ensures it can't be null then. Assert that, to hush the checker. Signed-off-by: Markus Armbruster --- hw/usb/hcd-ehci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 320b7e7..7040659 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2092,18 +2092,22 @@ static void ehci_advance_state(EHCIState *ehci, int async) break; case EST_ADVANCEQUEUE: + assert(q != NULL); again = ehci_state_advqueue(q); break; case EST_FETCHQTD: + assert(q != NULL); again = ehci_state_fetchqtd(q); break; case EST_HORIZONTALQH: + assert(q != NULL); again = ehci_state_horizqh(q); break; case EST_EXECUTE: + assert(q != NULL); again = ehci_state_execute(q); if (async) { ehci->async_stepdown = 0; -- 1.7.11.7