From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJ7q-00015O-Qj for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:29:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtJ7h-0001Ro-4k for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:28:58 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 10 Jan 2013 15:28:35 +0100 Message-Id: <1357828115-574-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH scsi-ish] raw-posix: fix bdrv_aio_ioctl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-stable@nongnu.org When the raw-posix aio=thread code was moved from posix-aio-compat.c to block/raw-posix.c, there was an unintended change to the ioctl code. The code used to return the ioctl command, which posix_aio_read() would later morph into a zero. This hack is not necessary anymore, and in fact breaks scsi-generic (which expects a zero return code). Remove it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- Kevin, if you prefer I can send this through the SCSI tree. block/raw-posix.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 87d888e..0e705ba 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -455,15 +455,7 @@ static ssize_t handle_aiocb_ioctl(RawPosixAIOData *aiocb) return -errno; } - /* - * This looks weird, but the aio code only considers a request - * successful if it has written the full number of bytes. - * - * Now we overload aio_nbytes as aio_ioctl_cmd for the ioctl command, - * so in fact we return the ioctl command here to make posix_aio_read() - * happy.. - */ - return aiocb->aio_nbytes; + return 0; } static ssize_t handle_aiocb_flush(RawPosixAIOData *aiocb) -- 1.8.1