From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Laurent@vivier.eu>) id 1TtPOI-00085M-Mg
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:10:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Laurent@vivier.eu>) id 1TtPOG-0001O0-Pu
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:10:22 -0500
Received: from moutng.kundenserver.de ([212.227.126.171]:61271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Laurent@vivier.eu>) id 1TtPOG-0001NV-Gt
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:10:20 -0500
Message-ID: <1357852201.3013.0.camel@Quad>
From: Laurent Vivier <Laurent@vivier.eu>
Date: Thu, 10 Jan 2013 22:10:01 +0100
In-Reply-To: <50EF2D25.4080601@twiddle.net>
References: <1357597486-19395-1-git-send-email-laurent@vivier.eu>
	<1357850568-7626-1-git-send-email-laurent@vivier.eu>
	<50EF2D25.4080601@twiddle.net>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH][v2] linux-user,
	alpha: l_type of fcntl() flock differs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org

Le jeudi 10 janvier 2013 =C3=A0 13:05 -0800, Richard Henderson a =C3=A9crit=
 :
> On 01/10/2013 12:42 PM, Laurent Vivier wrote:
> > +static const bitmask_transtbl flock_tbl[] =3D {
> > +    TRANSTBL_CONVERT(F_RDLCK),
> > +    TRANSTBL_CONVERT(F_WRLCK),
> > +    TRANSTBL_CONVERT(F_UNLCK),
> > +    TRANSTBL_CONVERT(F_EXLCK),
> > +    TRANSTBL_CONVERT(F_SHLCK),
> > +    { 0, 0, 0, 0 }
> > +};
>=20
> Oh, I forgot to mention that you'll need to protect against the
> case of F_RDLCK =3D=3D 0 && TARGET_F_RDLCK =3D=3D 0.  The easiest way to
> handle this is place that entry last.

Look at the macro, I put all masks to -1, is it a mistake ?

Regards,
Laurent
--=20
"Just play. Have fun. Enjoy the game."
- Michael Jordan