From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttakt-0008Vm-2U for qemu-devel@nongnu.org; Fri, 11 Jan 2013 04:18:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttako-0005eS-Lb for qemu-devel@nongnu.org; Fri, 11 Jan 2013 04:18:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttako-0005eF-Ek for qemu-devel@nongnu.org; Fri, 11 Jan 2013 04:18:22 -0500 From: Stefan Hajnoczi Date: Fri, 11 Jan 2013 10:18:01 +0100 Message-Id: <1357895886-14283-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1357895886-14283-1-git-send-email-stefanha@redhat.com> References: <1357895886-14283-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/6] readline: avoid memcpy() of overlapping regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Nickolai Zeldovich , Stefan Hajnoczi From: Nickolai Zeldovich memcpy() for overlapping regions is undefined behavior; use memmove() instead in readline_hist_add(). [Keep tab characters since surrounding code still uses them -- Stefan] Signed-off-by: Nickolai Zeldovich Reviewed-by: Richard Henderson Signed-off-by: Stefan Hajnoczi --- readline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readline.c b/readline.c index 5fc9643..a0c9638 100644 --- a/readline.c +++ b/readline.c @@ -248,8 +248,8 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline) if (idx == READLINE_MAX_CMDS) { /* Need to get one free slot */ free(rs->history[0]); - memcpy(rs->history, &rs->history[1], - (READLINE_MAX_CMDS - 1) * sizeof(char *)); + memmove(rs->history, &rs->history[1], + (READLINE_MAX_CMDS - 1) * sizeof(char *)); rs->history[READLINE_MAX_CMDS - 1] = NULL; idx = READLINE_MAX_CMDS - 1; } -- 1.8.0.2