From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnX-0006vh-Rj for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtbnT-0008GY-Tt for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:15 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:50745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnT-00086f-Ku for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:11 -0500 From: Markus Armbruster Date: Fri, 11 Jan 2013 11:24:58 +0100 Message-Id: <1357899902-5316-3-git-send-email-armbru@redhat.com> In-Reply-To: <1357899902-5316-1-git-send-email-armbru@redhat.com> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com After open(), the file offset is already zero, and neither lockf() nor ftruncate() change it. Signed-off-by: Markus Armbruster --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 47a6bea..1a22d8d 100644 --- a/qga/main.c +++ b/qga/main.c @@ -276,7 +276,7 @@ static bool ga_open_pidfile(const char *pidfile) return false; } - if (ftruncate(pidfd, 0) || lseek(pidfd, 0, SEEK_SET)) { + if (ftruncate(pidfd, 0)) { g_critical("Failed to truncate pid file"); goto fail; } -- 1.7.11.7