From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnX-0006vi-Vn for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtbnT-0008GP-Ry for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:15 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:50748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnT-00086b-L9 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:11 -0500 From: Markus Armbruster Date: Fri, 11 Jan 2013 11:24:59 +0100 Message-Id: <1357899902-5316-4-git-send-email-armbru@redhat.com> In-Reply-To: <1357899902-5316-1-git-send-email-armbru@redhat.com> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com Spotted by Coverity. Also document why we keep it open on success. Signed-off-by: Markus Armbruster --- qga/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qga/main.c b/qga/main.c index 1a22d8d..db47427 100644 --- a/qga/main.c +++ b/qga/main.c @@ -286,10 +286,12 @@ static bool ga_open_pidfile(const char *pidfile) goto fail; } + /* keep pidfile open & locked forever */ return true; fail: unlink(pidfile); + close(pidfd); return false; } #else /* _WIN32 */ -- 1.7.11.7