From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnW-0006va-Ey for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtbnT-0008GW-SF for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:14 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:50746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnT-00086h-Ki for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:11 -0500 From: Markus Armbruster Date: Fri, 11 Jan 2013 11:25:00 +0100 Message-Id: <1357899902-5316-5-git-send-email-armbru@redhat.com> In-Reply-To: <1357899902-5316-1-git-send-email-armbru@redhat.com> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com Spotted by Coverity. Signed-off-by: Markus Armbruster --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index d4fd628..5579185 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -45,6 +45,7 @@ static gboolean ga_channel_listen_accept(GIOChannel *channel, ret = ga_channel_client_add(c, client_fd); if (ret) { g_warning("error setting up connection"); + close(client_fd); goto out; } accepted = true; -- 1.7.11.7