From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnY-0006vn-TR for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtbnV-0008IR-5S for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:16 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:50758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnU-0008HR-V6 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:13 -0500 From: Markus Armbruster Date: Fri, 11 Jan 2013 11:25:01 +0100 Message-Id: <1357899902-5316-6-git-send-email-armbru@redhat.com> In-Reply-To: <1357899902-5316-1-git-send-email-armbru@redhat.com> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com Spotted by Coverity. Signed-off-by: Markus Armbruster --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index 5579185..b530808 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -153,6 +153,7 @@ static gboolean ga_channel_open(GAChannel *c, const gchar *path, GAChannelMethod ret = ga_channel_client_add(c, fd); if (ret) { g_critical("error adding channel to main loop"); + close(fd); return false; } break; -- 1.7.11.7