From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttbug-0002GS-GF for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:32:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttbue-0001ya-G9 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:32:38 -0500 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:53490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttbud-0001xw-Qp for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:32:36 -0500 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Jan 2013 16:01:31 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id F1C3AE0051 for ; Fri, 11 Jan 2013 16:02:43 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0BAWQPs48103644 for ; Fri, 11 Jan 2013 16:02:26 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0BAWRER021223 for ; Fri, 11 Jan 2013 21:32:27 +1100 From: Wenchao Xia Date: Fri, 11 Jan 2013 18:30:27 +0800 Message-Id: <1357900227-5228-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1357900227-5228-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1357900227-5228-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V2 2/2] oslib-win32: add lock for localtime_r() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, sw@weilnetz.de, pbonzini@redhat.com, Wenchao Xia Signed-off-by: Wenchao Xia --- v2: better comments and removed the code change localtime() to localtime_r(). --- oslib-win32.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/oslib-win32.c b/oslib-win32.c index 9a443da..aa1268c 100644 --- a/oslib-win32.c +++ b/oslib-win32.c @@ -90,15 +90,17 @@ struct tm *gmtime_r(const time_t *timep, struct tm *result) return p; } -/* FIXME: add proper locking */ +/* FIXME: make it thread safe in MinGW, remove the lock in qemu. */ struct tm *localtime_r(const time_t *timep, struct tm *result) { + g_static_mutex_lock(&time_lock); struct tm *p = localtime(timep); memset(result, 0, sizeof(*result)); if (p) { *result = *p; p = result; } + g_static_mutex_unlock(&time_lock); return p; } -- 1.7.1