From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttj6s-0001Tj-RY for qemu-devel@nongnu.org; Fri, 11 Jan 2013 13:13:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttj6q-00032j-TJ for qemu-devel@nongnu.org; Fri, 11 Jan 2013 13:13:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttj6q-00032K-LI for qemu-devel@nongnu.org; Fri, 11 Jan 2013 13:13:40 -0500 From: Eduardo Habkost Date: Fri, 11 Jan 2013 16:15:04 -0200 Message-Id: <1357928108-21066-7-git-send-email-ehabkost@redhat.com> In-Reply-To: <1357928108-21066-1-git-send-email-ehabkost@redhat.com> References: <1357928108-21066-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 06/10] vl.c: handle invalid NUMA CPU ranges properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Chegu Vinod , Anthony Liguori Add checks for the following cases: * Empty string: will be ignored and won't set any CPU bitmap, parser won't abort. * Missing end value after "-": parser will abort. * Extra characters after a valid CPU range: parser will abort. * "N-M" string where M < N: parser will abort. Signed-off-by: Eduardo Habkost --- vl.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 03a826e..19010fa 100644 --- a/vl.c +++ b/vl.c @@ -1057,13 +1057,30 @@ static void numa_node_parse_cpus(int nodenr, const char *cpus) char *endptr; unsigned long long value, endvalue; + /* Empty strings will be ignored, and not considered an error */ + if (!*cpus) { + return; + } + value = strtoull(cpus, &endptr, 10); if (*endptr == '-') { - endvalue = strtoull(endptr+1, &endptr, 10); + endptr++; + if (!*endptr) { + goto error; + } + endvalue = strtoull(endptr, &endptr, 10); } else { endvalue = value; } + if (*endptr != '\0') { + goto error; + } + + if (endvalue < value) { + goto error; + } + if (!(endvalue < MAX_CPUMASK_BITS)) { endvalue = MAX_CPUMASK_BITS - 1; fprintf(stderr, "A max of %d CPUs are supported in a guest\n", @@ -1071,6 +1088,11 @@ static void numa_node_parse_cpus(int nodenr, const char *cpus) } bitmap_set(node_cpumask[nodenr], value, endvalue-value+1); + return; + +error: + fprintf(stderr, "qemu: Invalid NUMA CPU range: %s\n", cpus); + exit(1); } static void numa_node_add(const char *optarg) -- 1.7.11.7