From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com,
armbru@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V3 01/11] qemu-img: remove unused parameter in collect_image_info()
Date: Mon, 14 Jan 2013 15:09:37 +0800 [thread overview]
Message-ID: <1358147387-8221-2-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1358147387-8221-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Parameter *fmt was not used, so remove it.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
qemu-img.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 85d3740..9dab48f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1186,8 +1186,7 @@ static void dump_json_image_info(ImageInfo *info)
static void collect_image_info(BlockDriverState *bs,
ImageInfo *info,
- const char *filename,
- const char *fmt)
+ const char *filename)
{
uint64_t total_sectors;
char backing_filename[1024];
@@ -1361,7 +1360,7 @@ static ImageInfoList *collect_image_info_list(const char *filename,
}
info = g_new0(ImageInfo, 1);
- collect_image_info(bs, info, filename, fmt);
+ collect_image_info(bs, info, filename);
collect_snapshots(bs, info);
elem = g_new0(ImageInfoList, 1);
--
1.7.1
next prev parent reply other threads:[~2013-01-14 7:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 7:09 [Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info Wenchao Xia
2013-01-14 7:09 ` Wenchao Xia [this message]
2013-01-14 17:08 ` [Qemu-devel] [PATCH V3 01/11] qemu-img: remove unused parameter in collect_image_info() Luiz Capitulino
2013-01-15 7:27 ` Wenchao Xia
2013-01-15 7:58 ` Wenchao Xia
2013-01-15 11:11 ` Luiz Capitulino
2013-01-16 3:10 ` Wenchao Xia
2013-01-16 17:56 ` Luiz Capitulino
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 02/11] block: add bdrv_get_filename() function Wenchao Xia
2013-01-14 17:08 ` Luiz Capitulino
2013-01-15 7:30 ` Wenchao Xia
2013-01-15 8:40 ` [Qemu-devel] IS_USER(s) in target-arm Shijesta Victor
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 03/11] block: add snapshot and image info query function Wenchao Xia
2013-01-14 17:22 ` Luiz Capitulino
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 04/11] qemu-img: switch image retrieving function Wenchao Xia
2013-01-14 11:25 ` Pavel Hrdina
2013-01-14 18:21 ` Luiz Capitulino
2013-01-15 2:37 ` Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 05/11] block: rename bdrv_query_info to bdrv_query_block_info Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 06/11] qmp: add interface query-images Wenchao Xia
2013-01-14 18:32 ` Luiz Capitulino
2013-01-15 10:27 ` Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot() Wenchao Xia
2013-01-14 23:39 ` Eric Blake
2013-01-15 10:24 ` Wenchao Xia
2013-01-15 17:57 ` Eric Blake
2013-01-16 4:28 ` Wenchao Xia
2013-01-15 12:01 ` Markus Armbruster
2013-01-15 13:18 ` Pavel Hrdina
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 08/11] qmp: add interface query-snapshots Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error() Wenchao Xia
2013-01-14 18:38 ` Luiz Capitulino
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 10/11] hmp: retrieve info from qmp for snapshot info Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 11/11] hmp: show snapshot on single block device Wenchao Xia
2013-01-14 11:15 ` Pavel Hrdina
2013-01-14 18:56 ` Luiz Capitulino
2013-01-15 2:36 ` Wenchao Xia
2013-01-15 11:05 ` Luiz Capitulino
2013-01-16 2:51 ` Wenchao Xia
2013-01-14 18:56 ` Luiz Capitulino
2013-01-14 18:58 ` [Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358147387-8221-2-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).