qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/6] block: do not probe zero-sized disks
Date: Mon, 14 Jan 2013 11:01:56 +0100	[thread overview]
Message-ID: <1358157721-4131-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1358157721-4131-1-git-send-email-kwolf@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

A blank CD or DVD is visible as a zero-sized disks.  Probing such
disks will lead to an EIO and a failure to start the VM.  Treating
them as raw is a better solution.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 60873ea..14f8202 100644
--- a/block.c
+++ b/block.c
@@ -527,7 +527,7 @@ static int find_image_format(BlockDriverState *bs, const char *filename,
     int ret = 0;
 
     /* Return the raw BlockDriver * to scsi-generic devices or empty drives */
-    if (bs->sg || !bdrv_is_inserted(bs)) {
+    if (bs->sg || !bdrv_is_inserted(bs) || bdrv_getlength(bs) == 0) {
         drv = bdrv_find_format("raw");
         if (!drv) {
             ret = -ENOENT;
-- 
1.7.6.5

  reply	other threads:[~2013-01-14 10:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 10:01 [Qemu-devel] [PULL 0/6] Block patches Kevin Wolf
2013-01-14 10:01 ` Kevin Wolf [this message]
2013-01-14 10:01 ` [Qemu-devel] [PATCH 2/6] sheepdog: implement direct write semantics Kevin Wolf
2013-01-14 10:01 ` [Qemu-devel] [PATCH 3/6] raw-posix: fix bdrv_aio_ioctl Kevin Wolf
2013-01-14 10:01 ` [Qemu-devel] [PATCH 4/6] block: make qiov_is_aligned() public Kevin Wolf
2013-01-14 10:02 ` [Qemu-devel] [PATCH 5/6] dataplane: extract virtio-blk read/write processing into do_rdwr_cmd() Kevin Wolf
2013-01-14 10:02 ` [Qemu-devel] [PATCH 6/6] dataplane: handle misaligned virtio-blk requests Kevin Wolf
2013-01-20 14:47 ` [Qemu-devel] [PULL 0/6] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358157721-4131-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).