From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tugrs-00052R-Q3 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:02:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tugrr-0006he-Qd for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:02:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tugrr-0006hG-IZ for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:02:11 -0500 From: Kevin Wolf Date: Mon, 14 Jan 2013 11:01:56 +0100 Message-Id: <1358157721-4131-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1358157721-4131-1-git-send-email-kwolf@redhat.com> References: <1358157721-4131-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 1/6] block: do not probe zero-sized disks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Paolo Bonzini A blank CD or DVD is visible as a zero-sized disks. Probing such disks will lead to an EIO and a failure to start the VM. Treating them as raw is a better solution. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 60873ea..14f8202 100644 --- a/block.c +++ b/block.c @@ -527,7 +527,7 @@ static int find_image_format(BlockDriverState *bs, const char *filename, int ret = 0; /* Return the raw BlockDriver * to scsi-generic devices or empty drives */ - if (bs->sg || !bdrv_is_inserted(bs)) { + if (bs->sg || !bdrv_is_inserted(bs) || bdrv_getlength(bs) == 0) { drv = bdrv_find_format("raw"); if (!drv) { ret = -ENOENT; -- 1.7.6.5