From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuiV2-0006l9-5X for qemu-devel@nongnu.org; Mon, 14 Jan 2013 06:46:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuiUw-00032X-3M for qemu-devel@nongnu.org; Mon, 14 Jan 2013 06:46:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuiUv-00032F-SO for qemu-devel@nongnu.org; Mon, 14 Jan 2013 06:46:38 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0EBka61021450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Jan 2013 06:46:36 -0500 From: Gerd Hoffmann Date: Mon, 14 Jan 2013 12:46:35 +0100 Message-Id: <1358163995-13462-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1358163995-13462-1-git-send-email-kraxel@redhat.com> References: <1358163995-13462-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] qxl: Don't drop client capability bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , Gerd Hoffmann From: Markus Armbruster interface_set_client_capabilities() copies only the first few bits, because it falls into a Classic C trap: you can declare a parameter uint8_t caps[58], but the resulting parameter type is uint8_t *, not uint8_t[58]. In particular, sizeof(caps) is sizeof(uint8_t *), not the intended sizeof(uint8_t[58]). Harmless, because the bits aren't used, yet. Broken in commit c10018d6. Spotted by Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e8f380b..9dc44b9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -951,9 +951,11 @@ static void interface_set_client_capabilities(QXLInstance *sin, } qxl->shadow_rom.client_present = client_present; - memcpy(qxl->shadow_rom.client_capabilities, caps, sizeof(caps)); + memcpy(qxl->shadow_rom.client_capabilities, caps, + sizeof(qxl->shadow_rom.client_capabilities)); qxl->rom->client_present = client_present; - memcpy(qxl->rom->client_capabilities, caps, sizeof(caps)); + memcpy(qxl->rom->client_capabilities, caps, + sizeof(qxl->rom->client_capabilities)); qxl_rom_set_dirty(qxl); qxl_send_events(qxl, QXL_INTERRUPT_CLIENT); -- 1.7.9.7