From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tumwj-0002K7-A8 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 11:31:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tumwf-0003pG-5f for qemu-devel@nongnu.org; Mon, 14 Jan 2013 11:31:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tumwe-0003p4-US for qemu-devel@nongnu.org; Mon, 14 Jan 2013 11:31:33 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0EGVWBP011823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Jan 2013 11:31:32 -0500 From: Kevin Wolf Date: Mon, 14 Jan 2013 17:31:31 +0100 Message-Id: <1358181091-3857-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] qcow2: Fix segfault on zero-length write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com One of the recent refactoring patches (commit f50f88b9) didn't take care to initialise l2meta properly, so with zero-length writes, which don't even enter the write loop, qemu just segfaulted. Signed-off-by: Kevin Wolf --- block/qcow2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 76c86a7..9c64917 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -759,7 +759,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, QEMUIOVector hd_qiov; uint64_t bytes_done = 0; uint8_t *cluster_data = NULL; - QCowL2Meta *l2meta; + QCowL2Meta *l2meta = NULL; trace_qcow2_writev_start_req(qemu_coroutine_self(), sector_num, remaining_sectors); -- 1.7.6.5