qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, armbru@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 1/8] qemu-ga: ga_open_pidfile(): use qemu_open()
Date: Mon, 14 Jan 2013 13:55:05 -0600	[thread overview]
Message-ID: <1358193312-15960-2-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1358193312-15960-1-git-send-email-mdroth@linux.vnet.ibm.com>

From: Luiz Capitulino <lcapitulino@redhat.com>

This ensures that O_CLOEXEC is passed to open(), this way the
pid file fd is not leaked to executed processes.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Amos Kong <akong@redhat.com>
Tested-by: Amos Kong <akong@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/main.c b/qga/main.c
index a9b968c..4239150 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -267,7 +267,7 @@ static bool ga_open_pidfile(const char *pidfile)
     int pidfd;
     char pidstr[32];
 
-    pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
+    pidfd = qemu_open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
     if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
         g_critical("Cannot lock pid file, %s", strerror(errno));
         if (pidfd != -1) {
-- 
1.7.9.5

  reply	other threads:[~2013-01-14 20:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:55 [Qemu-devel] [PULL 0/8] qemu-ga: cleanups and minor fixes Michael Roth
2013-01-14 19:55 ` Michael Roth [this message]
2013-01-14 19:55 ` [Qemu-devel] [PATCH 2/8] qemu-ga: add ga_open_logfile() Michael Roth
2013-01-14 19:55 ` [Qemu-devel] [PATCH 3/8] qemu-ga: Document intentional fall through in channel_event_cb() Michael Roth
2013-01-14 19:55 ` [Qemu-devel] [PATCH 4/8] qemu-ga: Drop pointless lseek() from ga_open_pidfile() Michael Roth
2013-01-14 19:55 ` [Qemu-devel] [PATCH 5/8] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path Michael Roth
2013-01-14 19:55 ` [Qemu-devel] [PATCH 6/8] qemu-ga: Plug fd leak on ga_channel_listen_accept() " Michael Roth
2013-01-14 19:55 ` [Qemu-devel] [PATCH 7/8] qemu-ga: Plug fd leak on ga_channel_open() error paths Michael Roth
2013-01-14 19:55 ` [Qemu-devel] [PATCH 8/8] qemu-ga: Handle errors uniformely in ga_channel_open() Michael Roth
2013-01-16  1:18 ` [Qemu-devel] [PULL 0/8] qemu-ga: cleanups and minor fixes Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358193312-15960-2-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).