From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuqCk-0001GU-A7 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 15:00:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuqCf-0008OS-Qd for qemu-devel@nongnu.org; Mon, 14 Jan 2013 15:00:22 -0500 Received: from mail-ie0-f171.google.com ([209.85.223.171]:52175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuqCf-0008Nu-D4 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 15:00:17 -0500 Received: by mail-ie0-f171.google.com with SMTP id 17so5720652iea.2 for ; Mon, 14 Jan 2013 12:00:16 -0800 (PST) Sender: fluxion From: Michael Roth Date: Mon, 14 Jan 2013 13:55:07 -0600 Message-Id: <1358193312-15960-4-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1358193312-15960-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1358193312-15960-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 3/8] qemu-ga: Document intentional fall through in channel_event_cb() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, armbru@redhat.com, lcapitulino@redhat.com From: Markus Armbruster For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Michael Roth Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/main.c b/qga/main.c index bd70ead..e8a9a9e 100644 --- a/qga/main.c +++ b/qga/main.c @@ -618,6 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data) if (!s->virtio) { return false; } + /* fall through */ case G_IO_STATUS_AGAIN: /* virtio causes us to spin here when no process is attached to * host-side chardev. sleep a bit to mitigate this -- 1.7.9.5