* [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean
@ 2013-01-15 7:47 Stefan Hajnoczi
2013-01-17 10:26 ` Stefan Hajnoczi
2013-01-20 20:53 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-01-15 7:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori, Stefan Hajnoczi
Commit eb8eb53e5846a957cf333f2e1ec8cb6e0c04 ("libcacard: rewrite
Makefile in non-recursive style") refactored libcacard/Makefile so it
can be included by the top-level Makefile.
The top-level clean target still loops over subdirectories, including
libcacard/, to invoke recursive clean. Remove libcacard from the
recursive clean since its files are already included at the top level.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 7622a4c..0ecfcda 100644
--- a/Makefile
+++ b/Makefile
@@ -226,7 +226,7 @@ clean:
rm -rf qapi-generated
rm -rf qga/qapi-generated
$(MAKE) -C tests/tcg clean
- for d in $(ALL_SUBDIRS) libcacard; do \
+ for d in $(ALL_SUBDIRS); do \
if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
rm -f $$d/qemu-options.def; \
done
--
1.8.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean
2013-01-15 7:47 [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean Stefan Hajnoczi
@ 2013-01-17 10:26 ` Stefan Hajnoczi
2013-01-20 20:53 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-01-17 10:26 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
On Tue, Jan 15, 2013 at 08:47:26AM +0100, Stefan Hajnoczi wrote:
> Commit eb8eb53e5846a957cf333f2e1ec8cb6e0c04 ("libcacard: rewrite
> Makefile in non-recursive style") refactored libcacard/Makefile so it
> can be included by the top-level Makefile.
>
> The top-level clean target still loops over subdirectories, including
> libcacard/, to invoke recursive clean. Remove libcacard from the
> recursive clean since its files are already included at the top level.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 7622a4c..0ecfcda 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -226,7 +226,7 @@ clean:
> rm -rf qapi-generated
> rm -rf qga/qapi-generated
> $(MAKE) -C tests/tcg clean
> - for d in $(ALL_SUBDIRS) libcacard; do \
> + for d in $(ALL_SUBDIRS); do \
> if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
> rm -f $$d/qemu-options.def; \
> done
Ping. Please apply so that make clean succeeds.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean
2013-01-15 7:47 [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean Stefan Hajnoczi
2013-01-17 10:26 ` Stefan Hajnoczi
@ 2013-01-20 20:53 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2013-01-20 20:53 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-20 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-15 7:47 [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean Stefan Hajnoczi
2013-01-17 10:26 ` Stefan Hajnoczi
2013-01-20 20:53 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).