From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 08/20] kvm: Add fake KVM constants to avoid #ifdefs on KVM-specific code
Date: Tue, 15 Jan 2013 10:27:26 +0100 [thread overview]
Message-ID: <1358242058-1404-9-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1358242058-1404-1-git-send-email-afaerber@suse.de>
From: Eduardo Habkost <ehabkost@redhat.com>
Any KVM-specific code that use these constants must check if
kvm_enabled() is true before using them.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
include/sysemu/kvm.h | 14 ++++++++++++++
1 Datei geändert, 14 Zeilen hinzugefügt(+)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index 2fe8f8a..6bdd513 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -22,6 +22,20 @@
#ifdef CONFIG_KVM
#include <linux/kvm.h>
#include <linux/kvm_para.h>
+#else
+/* These constants must never be used at runtime if kvm_enabled() is false.
+ * They exist so we don't need #ifdefs around KVM-specific code that already
+ * checks kvm_enabled() properly.
+ */
+#define KVM_CPUID_SIGNATURE 0
+#define KVM_CPUID_FEATURES 0
+#define KVM_FEATURE_CLOCKSOURCE 0
+#define KVM_FEATURE_NOP_IO_DELAY 0
+#define KVM_FEATURE_MMU_OP 0
+#define KVM_FEATURE_CLOCKSOURCE2 0
+#define KVM_FEATURE_ASYNC_PF 0
+#define KVM_FEATURE_STEAL_TIME 0
+#define KVM_FEATURE_PV_EOI 0
#endif
extern int kvm_allowed;
--
1.7.10.4
next prev parent reply other threads:[~2013-01-15 9:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 9:27 [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-15 Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 01/20] cpu: Move nr_{cores, threads} fields to CPUState Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 02/20] target-mips: Clean up mips_cpu_map_tc() documentation Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 03/20] cpu: Move numa_node field to CPUState Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 04/20] cpu: Move cpu_index " Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 05/20] kvm: Pass CPUState to kvm_init_vcpu() Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU Andreas Färber
2013-01-15 11:03 ` Stefano Stabellini
2013-01-15 14:46 ` Andreas Färber
2013-01-15 15:44 ` Stefano Stabellini
2013-01-15 9:27 ` [Qemu-devel] [PATCH 07/20] exec: Return CPUState from qemu_get_cpu() Andreas Färber
2013-01-15 9:27 ` Andreas Färber [this message]
2013-01-15 9:27 ` [Qemu-devel] [PATCH 09/20] target-i386: Disable kvm_mmu by default Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 10/20] target-i386/cpu: Introduce FeatureWord typedefs Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 11/20] target-i386: kvm_check_features_against_host(): Use feature_word_info Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 12/20] target-i386/cpu.c: Add feature name array for ext4_features Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 13/20] target-i386: check/enforce: Check all feature words Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 14/20] target-i386: Move setting defaults out of cpu_x86_parse_featurestr() Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 15/20] target-i386: cpu_x86_register() consolidate freeing resources Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 16/20] target-i386: Move kvm_check_features_against_host() check to realize time Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 17/20] target-i386: Define DR7 bit field constants Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 18/20] target-i386: Introduce hw_{local, global}_breakpoint_enabled() Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 19/20] target-i386: Avoid goto in hw_breakpoint_insert() Andreas Färber
2013-01-15 9:27 ` [Qemu-devel] [PATCH 20/20] target-i386: Use switch in check_hw_breakpoints() Andreas Färber
2013-01-16 1:18 ` [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-15 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358242058-1404-9-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).