From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv6UY-0006aJ-49 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 08:23:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv6UU-0003dp-4M for qemu-devel@nongnu.org; Tue, 15 Jan 2013 08:23:50 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:37944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv6UT-0003bs-SI for qemu-devel@nongnu.org; Tue, 15 Jan 2013 08:23:45 -0500 Received: from blackfin.pond.sub.org (p5B32AEB8.dip.t-dialin.net [91.50.174.184]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 43ACF9FE59 for ; Tue, 15 Jan 2013 14:23:41 +0100 (CET) From: Markus Armbruster Date: Tue, 15 Jan 2013 14:23:40 +0100 Message-Id: <1358256220-5460-5-git-send-email-armbru@redhat.com> In-Reply-To: <1358256220-5460-1-git-send-email-armbru@redhat.com> References: <1358256220-5460-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com It allocates with qemu_blockalign(), therefore it must free with qemu_vfree(), not g_free(). Since I'm touching it anyway, move the free to a more obviosly correct place. Signed-off-by: Markus Armbruster --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8aeacbf..27a7d8c 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -223,9 +223,9 @@ static void coroutine_fn mirror_run(void *opaque) break; } } + qemu_vfree(s->buf); immediate_exit: - g_free(s->buf); bdrv_set_dirty_tracking(bs, false); bdrv_iostatus_disable(s->target); if (s->should_complete && ret == 0) { -- 1.7.11.7