From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7RB-0005lW-7E for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:24:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv7R5-00052B-OQ for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:24:25 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:38088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7R5-00051m-I9 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:24:19 -0500 From: Markus Armbruster Date: Tue, 15 Jan 2013 15:24:15 +0100 Message-Id: <1358259856-9422-2-git-send-email-armbru@redhat.com> In-Reply-To: <1358259856-9422-1-git-send-email-armbru@redhat.com> References: <1358259856-9422-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] acl: Fix acl_remove not to mess up the ACL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, aliguori@us.ibm.com It leaks memory and fails to adjust qemu_acl member nentries. Future acl_add become confused: can misreport the position, and can silently fail to add. Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster --- util/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/acl.c b/util/acl.c index 81ac255..21b2205 100644 --- a/util/acl.c +++ b/util/acl.c @@ -168,6 +168,9 @@ int qemu_acl_remove(qemu_acl *acl, i++; if (strcmp(entry->match, match) == 0) { QTAILQ_REMOVE(&acl->entries, entry, next); + acl->nentries--; + g_free(entry->match); + g_free(entry); return i; } } -- 1.7.11.7