From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7Vo-000440-TR for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:29:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv7Vn-0006UR-KK for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:29:12 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:38110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7Vn-0006U9-Di for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:29:11 -0500 Received: from blackfin.pond.sub.org (p5B32AEB8.dip.t-dialin.net [91.50.174.184]) by oxygen.pond.sub.org (Postfix) with ESMTPA id B75309FE58 for ; Tue, 15 Jan 2013 15:29:10 +0100 (CET) From: Markus Armbruster Date: Tue, 15 Jan 2013 15:29:08 +0100 Message-Id: <1358260150-9760-3-git-send-email-armbru@redhat.com> In-Reply-To: <1358260150-9760-1-git-send-email-armbru@redhat.com> References: <1358260150-9760-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com Signed-off-by: Markus Armbruster --- hw/scsi-disk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f8d7ef3..96db9a7 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -85,9 +85,7 @@ static void scsi_free_request(SCSIRequest *req) { SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req); - if (r->iov.iov_base) { - qemu_vfree(r->iov.iov_base); - } + qemu_vfree(r->iov.iov_base); } /* Helper function for command completion with sense. */ -- 1.7.11.7