From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv9hI-00031i-7m for qemu-devel@nongnu.org; Tue, 15 Jan 2013 11:49:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv9hE-0005pt-HZ for qemu-devel@nongnu.org; Tue, 15 Jan 2013 11:49:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv9hE-0005p3-9J for qemu-devel@nongnu.org; Tue, 15 Jan 2013 11:49:08 -0500 From: Stefan Hajnoczi Date: Tue, 15 Jan 2013 17:48:29 +0100 Message-Id: <1358268511-27061-14-git-send-email-stefanha@redhat.com> In-Reply-To: <1358268511-27061-1-git-send-email-stefanha@redhat.com> References: <1358268511-27061-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 13/15] scsi-disk: qemu_vfree(NULL) is fine, simplify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi From: Markus Armbruster Signed-off-by: Markus Armbruster Acked-by: Paolo Bonzini Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/scsi-disk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f8d7ef3..96db9a7 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -85,9 +85,7 @@ static void scsi_free_request(SCSIRequest *req) { SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req); - if (r->iov.iov_base) { - qemu_vfree(r->iov.iov_base); - } + qemu_vfree(r->iov.iov_base); } /* Helper function for command completion with sense. */ -- 1.8.0.2