From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvPhf-0008AD-QN for qemu-devel@nongnu.org; Wed, 16 Jan 2013 04:54:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvPhe-000470-Hw for qemu-devel@nongnu.org; Wed, 16 Jan 2013 04:54:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvPhe-00046v-9w for qemu-devel@nongnu.org; Wed, 16 Jan 2013 04:54:38 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0G9sbHg016584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 16 Jan 2013 04:54:37 -0500 From: Kevin Wolf Date: Wed, 16 Jan 2013 10:54:34 +0100 Message-Id: <1358330074-18475-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] ide: Remove wrong assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when the request is still in flight, but also when it has completed and the size of the physical memory regions in the PRDT was larger than the transfer size. Signed-off-by: Kevin Wolf --- hw/ide/pci.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index e6226e3..59fd539 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -311,7 +311,6 @@ void bmdma_cmd_writeb(BMDMAState *bm, uint32_t val) if (bm->bus->dma->aiocb) { bdrv_drain_all(); assert(bm->bus->dma->aiocb == NULL); - assert((bm->status & BM_STATUS_DMAING) == 0); } } else { bm->cur_addr = bm->addr; -- 1.7.6.5