From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvTO7-0002GW-IZ for qemu-devel@nongnu.org; Wed, 16 Jan 2013 08:50:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvTO3-0007LF-Qu for qemu-devel@nongnu.org; Wed, 16 Jan 2013 08:50:43 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:41535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvTO3-0007Kd-KK for qemu-devel@nongnu.org; Wed, 16 Jan 2013 08:50:39 -0500 From: Markus Armbruster Date: Wed, 16 Jan 2013 14:50:25 +0100 Message-Id: <1358344229-18006-5-git-send-email-armbru@redhat.com> In-Reply-To: <1358344229-18006-1-git-send-email-armbru@redhat.com> References: <1358344229-18006-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 4/8] pc: Fix unchecked strdup() by switching to fw_cfg_add_string() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, gleb@redhat.com Signed-off-by: Markus Armbruster --- hw/pc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index ba1f19d..bc5c33f 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -693,9 +693,7 @@ static void load_linux(void *fw_cfg, fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_ADDR, cmdline_addr); fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE, strlen(kernel_cmdline)+1); - fw_cfg_add_bytes(fw_cfg, FW_CFG_CMDLINE_DATA, - (uint8_t*)strdup(kernel_cmdline), - strlen(kernel_cmdline)+1); + fw_cfg_add_string(fw_cfg, FW_CFG_CMDLINE_DATA, kernel_cmdline); if (protocol >= 0x202) { stl_p(header+0x228, cmdline_addr); -- 1.7.11.7