From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6f-0000DA-VA for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvU6c-000268-87 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:45 -0500 From: Markus Armbruster Date: Wed, 16 Jan 2013 15:36:38 +0100 Message-Id: <1358346998-26328-12-git-send-email-armbru@redhat.com> In-Reply-To: <1358346998-26328-1-git-send-email-armbru@redhat.com> References: <1358346998-26328-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org I figure it's freed somewhere deep down in QAPI, with g_free(). Signed-off-by: Markus Armbruster --- qga/commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands.c b/qga/commands.c index 7ffb35e..528b082 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -61,7 +61,7 @@ struct GuestAgentInfo *qmp_guest_info(Error **err) while (*cmd_list) { cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo)); - cmd_info->name = strdup(*cmd_list); + cmd_info->name = g_strdup(*cmd_list); cmd_info->enabled = qmp_command_is_enabled(cmd_info->name); cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList)); -- 1.7.11.7