From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 13/21] qxl+vnc: register a vm state change handler for dummy spice_server
Date: Wed, 16 Jan 2013 10:49:15 -0600 [thread overview]
Message-ID: <1358354963-9070-14-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1358354963-9070-1-git-send-email-mdroth@linux.vnet.ibm.com>
From: Uri Lublin <uril@redhat.com>
When qxl + vnc are used, a dummy spice_server is initialized.
The spice_server has to be told when the VM runstate changes,
which is what this patch does.
Without it, from qxl_send_events(), the following error message is shown:
qxl_send_events: spice-server bug: guest stopped, ignoring
Cc: qemu-stable@nongnu.org
Signed-off-by: Uri Lublin <uril@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 938b8a36b65e44c44ca29245437f8d7ac0f826e8)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
ui/spice-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 261c6f2..59ce5f6 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -732,6 +732,8 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
*/
spice_server = spice_server_new();
spice_server_init(spice_server, &core_interface);
+ qemu_add_vm_change_state_handler(vm_change_state_handler,
+ &spice_server);
}
return spice_server_add_interface(spice_server, sin);
--
1.7.9.5
next prev parent reply other threads:[~2013-01-16 16:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 16:49 [Qemu-devel] Patch Round-up for stable 1.3.1, freeze Monday Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 01/21] Fix semaphores fallback code Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 02/21] Disable semaphores fallback code for OpenBSD Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 03/21] Fix off-by-1 error in RAM migration code Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 04/21] migration: Fix madvise breakage if host and guest have different page sizes Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 05/21] target-mips: Fix incorrect code and test for INSV Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 06/21] target-mips: Fix incorrect shift for SHILO and SHILOV Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 07/21] vfio-pci: Don't use kvm_irqchip_in_kernel Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 08/21] seabios: update to e8a76b0f225bba5ba9d63ab227e0a37b3beb1059 Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 09/21] Update seabios to a810e4e72a0d42c7bc04eda57382f8e019add901 Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 10/21] pixman: fix vnc tight png/jpeg support Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 11/21] target-xtensa: fix ITLB/DTLB page protection flags Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 12/21] qxl: save qemu_create_displaysurface_from result Michael Roth
2013-01-16 16:49 ` Michael Roth [this message]
2013-01-16 16:49 ` [Qemu-devel] [PATCH 14/21] e1000: Discard oversized packets based on SBP|LPE Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 15/21] migration: fix migration_bitmap leak Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 16/21] buffered_file: do not send more than s->bytes_xfer bytes per tick Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 17/21] target-xtensa: fix search_pc for the last TB opcode Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 18/21] vfio-pci: Make host MSI-X enable track guest Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 19/21] pci-assign: Enable MSIX on device to match guest Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 20/21] vfio-pci: Loosen sanity checks to allow future features Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 21/21] raw-posix: fix bdrv_aio_ioctl Michael Roth
2013-01-16 18:12 ` [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.3.1, freeze Monday Michael Tokarev
2013-01-16 18:56 ` mdroth
2013-01-16 21:21 ` Michael Tokarev
2013-01-19 1:59 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358354963-9070-14-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).