qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 07/21] vfio-pci: Don't use kvm_irqchip_in_kernel
Date: Wed, 16 Jan 2013 10:49:09 -0600	[thread overview]
Message-ID: <1358354963-9070-8-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1358354963-9070-1-git-send-email-mdroth@linux.vnet.ibm.com>

From: Alex Williamson <alex.williamson@redhat.com>

kvm_irqchip_in_kernel() has an architecture specific meaning, so
we shouldn't be using it to determine whether to enabled KVM INTx
bypass.  kvm_irqfds_enabled() seems most appropriate.  Also use this
to protect our other call to kvm_check_extension() as that explodes
when KVM isn't enabled.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-stable@nongnu.org
(cherry picked from commit d281084d3e51f03999d12a506491a0c6f31b40e8)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 hw/vfio_pci.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
index 7c27834..fbfe670 100644
--- a/hw/vfio_pci.c
+++ b/hw/vfio_pci.c
@@ -275,7 +275,7 @@ static void vfio_enable_intx_kvm(VFIODevice *vdev)
     int ret, argsz;
     int32_t *pfd;
 
-    if (!kvm_irqchip_in_kernel() ||
+    if (!kvm_irqfds_enabled() ||
         vdev->intx.route.mode != PCI_INTX_ENABLED ||
         !kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
         return;
@@ -438,7 +438,8 @@ static int vfio_enable_intx(VFIODevice *vdev)
      * Only conditional to avoid generating error messages on platforms
      * where we won't actually use the result anyway.
      */
-    if (kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
+    if (kvm_irqfds_enabled() &&
+        kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
         vdev->intx.route = pci_device_route_intx_to_irq(&vdev->pdev,
                                                         vdev->intx.pin);
     }
-- 
1.7.9.5

  parent reply	other threads:[~2013-01-16 16:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 16:49 [Qemu-devel] Patch Round-up for stable 1.3.1, freeze Monday Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 01/21] Fix semaphores fallback code Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 02/21] Disable semaphores fallback code for OpenBSD Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 03/21] Fix off-by-1 error in RAM migration code Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 04/21] migration: Fix madvise breakage if host and guest have different page sizes Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 05/21] target-mips: Fix incorrect code and test for INSV Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 06/21] target-mips: Fix incorrect shift for SHILO and SHILOV Michael Roth
2013-01-16 16:49 ` Michael Roth [this message]
2013-01-16 16:49 ` [Qemu-devel] [PATCH 08/21] seabios: update to e8a76b0f225bba5ba9d63ab227e0a37b3beb1059 Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 09/21] Update seabios to a810e4e72a0d42c7bc04eda57382f8e019add901 Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 10/21] pixman: fix vnc tight png/jpeg support Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 11/21] target-xtensa: fix ITLB/DTLB page protection flags Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 12/21] qxl: save qemu_create_displaysurface_from result Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 13/21] qxl+vnc: register a vm state change handler for dummy spice_server Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 14/21] e1000: Discard oversized packets based on SBP|LPE Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 15/21] migration: fix migration_bitmap leak Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 16/21] buffered_file: do not send more than s->bytes_xfer bytes per tick Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 17/21] target-xtensa: fix search_pc for the last TB opcode Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 18/21] vfio-pci: Make host MSI-X enable track guest Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 19/21] pci-assign: Enable MSIX on device to match guest Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 20/21] vfio-pci: Loosen sanity checks to allow future features Michael Roth
2013-01-16 16:49 ` [Qemu-devel] [PATCH 21/21] raw-posix: fix bdrv_aio_ioctl Michael Roth
2013-01-16 18:12 ` [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.3.1, freeze Monday Michael Tokarev
2013-01-16 18:56   ` mdroth
2013-01-16 21:21     ` Michael Tokarev
2013-01-19  1:59 ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358354963-9070-8-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).