* [Qemu-devel] [PATCH] usb-storage: Drop useless null test in usb_msd_handle_data()
@ 2013-01-16 17:20 Markus Armbruster
2013-01-16 21:13 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2013-01-16 17:20 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
scsi_req_new() never returns null, and scsi_req_enqueue() dereferences
the pointer, so checking for null is useless.
Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/usb/dev-storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 1b87352..b839798 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -427,7 +427,7 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p)
scsi_req_print(s->req);
#endif
scsi_req_enqueue(s->req);
- if (s->req && s->req->cmd.xfer != SCSI_XFER_NONE) {
+ if (s->req->cmd.xfer != SCSI_XFER_NONE) {
scsi_req_continue(s->req);
}
break;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] usb-storage: Drop useless null test in usb_msd_handle_data()
2013-01-16 17:20 [Qemu-devel] [PATCH] usb-storage: Drop useless null test in usb_msd_handle_data() Markus Armbruster
@ 2013-01-16 21:13 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2013-01-16 21:13 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: kraxel
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-16 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 17:20 [Qemu-devel] [PATCH] usb-storage: Drop useless null test in usb_msd_handle_data() Markus Armbruster
2013-01-16 21:13 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).