From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWf6-0003UM-F7 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:20:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvWf5-000688-CM for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:20:28 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:42140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWf5-000682-6M for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:20:27 -0500 Received: from blackfin.pond.sub.org (p5B32B5E9.dip.t-dialin.net [91.50.181.233]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 9267F9FE57 for ; Wed, 16 Jan 2013 18:20:26 +0100 (CET) From: Markus Armbruster Date: Wed, 16 Jan 2013 18:20:25 +0100 Message-Id: <1358356825-28957-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] usb-storage: Drop useless null test in usb_msd_handle_data() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com scsi_req_new() never returns null, and scsi_req_enqueue() dereferences the pointer, so checking for null is useless. Spotted by Coverity. Signed-off-by: Markus Armbruster --- hw/usb/dev-storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 1b87352..b839798 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -427,7 +427,7 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p) scsi_req_print(s->req); #endif scsi_req_enqueue(s->req); - if (s->req && s->req->cmd.xfer != SCSI_XFER_NONE) { + if (s->req->cmd.xfer != SCSI_XFER_NONE) { scsi_req_continue(s->req); } break; -- 1.7.11.7