qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-stable@nongnu.org,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] win32-aio: Fix vectored reads
Date: Wed, 16 Jan 2013 21:19:59 +0100	[thread overview]
Message-ID: <1358367600-8074-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1358367600-8074-1-git-send-email-kwolf@redhat.com>

Copying data in the right direction really helps a lot!

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/win32-aio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/win32-aio.c b/block/win32-aio.c
index 46a5db7..53b82e6 100644
--- a/block/win32-aio.c
+++ b/block/win32-aio.c
@@ -84,7 +84,7 @@ static void win32_aio_process_completion(QEMUWin32AIOState *s,
             int i;
 
             for (i = 0; i < qiov->niov; ++i) {
-                memcpy(p, qiov->iov[i].iov_base, qiov->iov[i].iov_len);
+                memcpy(qiov->iov[i].iov_base, p, qiov->iov[i].iov_len);
                 p += qiov->iov[i].iov_len;
             }
             g_free(waiocb->buf);
-- 
1.7.6.5

  reply	other threads:[~2013-01-16 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 20:19 [Qemu-devel] [PATCH 0/2] win32-aio fixes Kevin Wolf
2013-01-16 20:19 ` Kevin Wolf [this message]
2013-01-17  8:33   ` [Qemu-devel] [Qemu-stable] [PATCH 1/2] win32-aio: Fix vectored reads Michael Tokarev
2013-01-17  8:43     ` Kevin Wolf
2013-01-16 20:20 ` [Qemu-devel] [PATCH 2/2] win32-aio: Fix memory leak Kevin Wolf
2013-01-17  9:59 ` [Qemu-devel] [PATCH 0/2] win32-aio fixes Stefan Hajnoczi
2013-01-17 10:53 ` Paolo Bonzini
2013-01-17 11:35   ` Kevin Wolf
2013-01-17 11:37     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358367600-8074-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).