qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH qom-cpu 0/5] x86 CPU cleanup, part 4
Date: Thu, 17 Jan 2013 16:16:29 +0100	[thread overview]
Message-ID: <1358435794-8406-1-git-send-email-imammedo@redhat.com> (raw)


It's rebase of remnants of "[PATCH qom-cpu 00/17] x86 CPU cleanup, part 3" [1]
taking in account comments of reviewers.

This series is several cleanups, moved out from CPU properties series,
since they do not really depend on CPU properties re-factoring and could
simplify CPU subclasses work as well.

Series doesn't depend on cpu as device or any other series, and applies
to current master.

git tree for testing:
    https://github.com/imammedo/qemu/tree/x86_cpu_cleanup.part4

vendor related changes are tested with:
  https://github.com/imammedo/virt-test/tree/cpuid_features
  following command was used to run test:
   ./run -t kvm --qemu-bin=$QEMU --tests="qemu_cpu.qemu13 cpuid.custom_vendor"

*1 - http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01732.html

v6:
 - patches 1-3 from previous series already in master, dropped
 - patches 4-5 from previous series are sqashed in one
 - patches 7-8,10-17 from previous series are sqashed in one and
   cpu_x86_parse_featurestr() rewritten to set properties directly on CPU

v5:
 - dropped patch
   "[PATCH 06/20] target-i386: move out CPU features initialization in separate func"
   due to Andreas objection
 - fixed x86cpu to x86_cpu new function prefixes
 - rebased on top of "disable kvm_mmu + -cpu "enforce" fixes (v3)" due conflicts
 - patches 1-4 from "[PATCH 00/20 v4] x86 CPU cleanup (wave 2)", already
   in master. So dropped from here
 - added patches 16-17 to deal with tsc_freq parsing without introducing
   new new visitor

v4:
 - rename [01/20] from:
     target-i386: filter out not TCG features if running without kvm at
       realize time
   to:
     target-i386: filter out unsupported features at realize time
 - make commit lines shorter for:
     target-i386: move kvm_check_features_against_host() check to realize
       time
 - restore removed by mistake host_cpuid() call in:
     target-i386: replace uint32_t vendor fields by vendor string in x86_def_t
 - fix spelling in:
     target-i386: print depricated warning if xlevel < 0x80000000
 - use qstring_append_int() for converting xlevel to string in:
     target-i386: set custom 'xlevel' without intermediate x86_def_t

v3:
 - [07/20] sets error if cpu name is empty, restore return -1 on error
 - get rid of *vendor_override field in CPUX86State & co
 - mark xlevel < 0x80000000 as depricated
 - squash idef-ing kvm specific functions in [08/20]
 - expand comment of [12/20] and reorder it right before "set custom" patches

v2:
 - cleanup commit message  and style fixes in
     [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time
 - extracted more patches [07-20] from cpu properties series, that were
   more cleanups and code reorganizing than conversion to static properties.

Igor Mammedov (5):
  target-i386: print deprecated warning if xlevel < 0x80000000
  target-i386: replace uint32_t vendor fields by vendor string in
    x86_def_t
  target-i386: remove vendor_override field from CPUX86State
  target-i386: set custom features/properties without intermediate
    x86_def_t
  target-i386: remove setting tsc-frequency from x86_def_t

 target-i386/cpu.c |  322 ++++++++++++++++++++++-------------------------------
 target-i386/cpu.h |    7 +-
 2 files changed, 138 insertions(+), 191 deletions(-)

             reply	other threads:[~2013-01-17 15:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 15:16 Igor Mammedov [this message]
2013-01-17 15:16 ` [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000 Igor Mammedov
2013-01-21  8:39   ` Andreas Färber
2013-01-21 12:14     ` Igor Mammedov
2013-01-17 15:16 ` [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t Igor Mammedov
2013-01-17 15:29   ` Eduardo Habkost
2013-01-18  7:12   ` li guang
2013-01-18 13:40     ` Igor Mammedov
2013-01-21  3:16       ` li guang
2013-01-21  8:18   ` Andreas Färber
2013-01-17 15:16 ` [Qemu-devel] [PATCH 3/5] target-i386: remove vendor_override field from CPUX86State Igor Mammedov
2013-01-17 15:30   ` Eduardo Habkost
2013-01-17 15:16 ` [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t Igor Mammedov
2013-01-17 17:44   ` Eduardo Habkost
2013-01-18 14:49     ` Igor Mammedov
2013-01-17 15:16 ` [Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from x86_def_t Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358435794-8406-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).